From c167b1c08e732d36e4ec343fb10d814dcbd4a792 Mon Sep 17 00:00:00 2001
From: ArtOfCode- <hello@artofcode.co.uk>
Date: Tue, 4 Aug 2020 15:28:32 +0100
Subject: [PATCH] Ternary instead of logical ORs

---
 app/views/layouts/_head.html.erb | 3 ++-
 app/views/posts/_form.html.erb   | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/app/views/layouts/_head.html.erb b/app/views/layouts/_head.html.erb
index 4eba830da..7a67e3c69 100644
--- a/app/views/layouts/_head.html.erb
+++ b/app/views/layouts/_head.html.erb
@@ -11,7 +11,8 @@
   <%= page_title %>
 </title>
 
-<link rel="icon" href="<%= SiteSetting['IconPath'] || '/assets/favicon.ico' %>" />
+<% icon_path = SiteSetting['IconPath'] %>
+<link rel="icon" href="<%= icon_path.present? ? icon_path : '/assets/favicon.ico' %>" />
 
 <%= stylesheet_link_tag "https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.11.2/css/all.min.css" %>
 <%= stylesheet_link_tag "https://unpkg.com/@codidact/co-design@0.12.0/dist/codidact.css" %>
diff --git a/app/views/posts/_form.html.erb b/app/views/posts/_form.html.erb
index 426dcc37a..91758e9ce 100644
--- a/app/views/posts/_form.html.erb
+++ b/app/views/posts/_form.html.erb
@@ -7,8 +7,8 @@
 <div class="notice is-info">
   <p><strong>Posting Tips</strong></p>
   <div class="has-font-size-caption">
-  <% guidance = @category.asking_guidance_override || SiteSetting['AskingGuidance'] %>
-    <%= raw(sanitize(render_markdown(guidance), scrubber: scrubber)) %>
+  <% guidance = @category.asking_guidance_override %>
+  <%= raw(sanitize(render_markdown(guidance.present? ? guidance : SiteSetting['AskingGuidance']), scrubber: scrubber)) %>
   </div>
 </div>
 
-- 
GitLab