From 0e71b454f3620e26b23598fc45d5f226b9c937c4 Mon Sep 17 00:00:00 2001
From: Luc Everse <luc@wukl.net>
Date: Mon, 29 Aug 2022 18:36:31 +0200
Subject: [PATCH] Only send access-level-less feedback when public is allowed
---
.../ewi/auta/core/report/ReportAuthorizationFilter.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/core/src/main/java/nl/tudelft/ewi/auta/core/report/ReportAuthorizationFilter.java b/core/src/main/java/nl/tudelft/ewi/auta/core/report/ReportAuthorizationFilter.java
index bb3297aeb..2028ea15b 100644
--- a/core/src/main/java/nl/tudelft/ewi/auta/core/report/ReportAuthorizationFilter.java
+++ b/core/src/main/java/nl/tudelft/ewi/auta/core/report/ReportAuthorizationFilter.java
@@ -9,6 +9,7 @@ import org.jetbrains.annotations.Contract;
import org.springframework.stereotype.Service;
import javax.annotation.Nullable;
+import java.util.Objects;
import java.util.Set;
import java.util.stream.Collectors;
@@ -105,7 +106,8 @@ public class ReportAuthorizationFilter {
final var filteredNotes = new NoteCollection();
filteredNotes.setNotes(report.getNotes().getNotes().stream()
.filter(n ->
- n.getAccessLevel() == null || accessLevels.contains(n.getAccessLevel())
+ (n.getAccessLevel() == null && accessLevels.contains(AccessLevel.PUBLIC))
+ || (n.getAccessLevel() != null && accessLevels.contains(n.getAccessLevel()))
)
.collect(Collectors.toUnmodifiableList())
);
--
GitLab