Skip to content

Follow-up from ""Create a post-lab statistics page""

The following discussion from !211 (merged) should be addressed:

  • @otto started a discussion:

    max indentation level exceeded 📦

Plus code quality wise:

Method `getRequestFrequencies` has 5 arguments (exceeds 4 allowed). Consider refactoring. 
in src/main/java/nl/tudelft/ewi/queue/controller/CourseStatusController.java:77
Function `drawRequestFreqChart` has 70 lines of code (exceeds 25 allowed). Consider refactoring. 
in src/main/resources/static/js/lab_status_charts.js:23
Function `drawStatusFreqChart` has 48 lines of code (exceeds 25 allowed). Consider refactoring. 
in src/main/resources/static/js/lab_status_charts.js:98
Function `drawAssignmentFreqChart` has 39 lines of code (exceeds 25 allowed). Consider refactoring. 
in src/main/resources/static/js/lab_status_charts.js:149
Function `drawRoomFreqChart` has 39 lines of code (exceeds 25 allowed). Consider refactoring. 
in src/main/resources/static/js/lab_status_charts.js:192
Similar blocks of code found in 2 locations. Consider refactoring. 
in src/main/resources/static/js/lab_status_charts.js:149
Similar blocks of code found in 2 locations. Consider refactoring. 
in src/main/resources/static/js/lab_status_charts.js:192
Similar blocks of code found in 2 locations. Consider refactoring. 
in src/main/resources/static/js/lab_status_charts.js:34
Similar blocks of code found in 2 locations. Consider refactoring. 
in src/main/resources/static/js/lab_status_charts.js:45
Use ‘===’ to compare with ‘null’. 
in src/main/resources/static/js/lab_status_charts.js:33
Expected '!==' and instead saw '!='. 
in src/main/resources/static/js/lab_status_charts.js:33
Use ‘===’ to compare with ‘null’. 
in src/main/resources/static/js/lab_status_charts.js:100
Expected '!==' and instead saw '!='. 
in src/main/resources/static/js/lab_status_charts.js:100
Use ‘===’ to compare with ‘null’. 
in src/main/resources/static/js/lab_status_charts.js:154
Expected '!==' and instead saw '!='. 
in src/main/resources/static/js/lab_status_charts.js:154
Use ‘===’ to compare with ‘null’. 
in src/main/resources/static/js/lab_status_charts.js:197
Expected '!==' and instead saw '!='. 
in src/main/resources/static/js/lab_status_charts.js:197