Project Forum merge requestshttps://gitlab.ewi.tudelft.nl/eip/projectforum/projectforum/-/merge_requests2024-03-25T11:53:56+01:00https://gitlab.ewi.tudelft.nl/eip/projectforum/projectforum/-/merge_requests/1090Use display name instead of first+last name2024-03-25T11:53:56+01:00Rok ŠtularUse display name instead of first+last nameCloses #711Closes #711Rok ŠtularRok Štularhttps://gitlab.ewi.tudelft.nl/eip/projectforum/projectforum/-/merge_requests/1121Add option to export project descriptions as HTML/PDF2024-03-25T11:47:16+01:00Rok ŠtularAdd option to export project descriptions as HTML/PDFCloses #702Closes #702Rok ŠtularRok Štularhttps://gitlab.ewi.tudelft.nl/eip/projectforum/projectforum/-/merge_requests/1094Front page: add active proposals2024-03-25T11:24:01+01:00Anna KalandadzeFront page: add active proposalsCloses #720
This is ready for review, but do not merge until login page is restructuredCloses #720
This is ready for review, but do not merge until login page is restructuredhttps://gitlab.ewi.tudelft.nl/eip/projectforum/projectforum/-/merge_requests/1112Draft: Translate more views 3rd batch2024-03-20T12:06:38+01:00Jegor ZelenjakDraft: Translate more views 3rd batchJegor ZelenjakJegor Zelenjakhttps://gitlab.ewi.tudelft.nl/eip/projectforum/projectforum/-/merge_requests/1119Draft: Add content security policy2024-03-04T12:04:40+01:00Martin Mladenovm.mladenov@student.tudelft.nlDraft: Add content security policyInitially, we can set up an unenforced report-only policy, so that we see if there are any false positives without breaking the website.
Related to #735 (we can close it after the policy is enforced)Initially, we can set up an unenforced report-only policy, so that we see if there are any false positives without breaking the website.
Related to #735 (we can close it after the policy is enforced)https://gitlab.ewi.tudelft.nl/eip/projectforum/projectforum/-/merge_requests/980Draft: Add audit log2024-02-19T11:41:18+01:00Martin Mladenovm.mladenov@student.tudelft.nlDraft: Add audit logCloses #74Closes #74https://gitlab.ewi.tudelft.nl/eip/projectforum/projectforum/-/merge_requests/1037Draft: Restructure themes and thesis projects2023-12-07T10:18:33+01:00Martin Mladenovm.mladenov@student.tudelft.nlDraft: Restructure themes and thesis projectsDB:
- [x] Make an n x n `programme - theme` relation based on the existing `programme - research group - theme` relation (the diagram says n x 1 but I'm pretty sure that's wrong)
- [x] Remove the `programme - research group` relation
- [...DB:
- [x] Make an n x n `programme - theme` relation based on the existing `programme - research group - theme` relation (the diagram says n x 1 but I'm pretty sure that's wrong)
- [x] Remove the `programme - research group` relation
- [x] Change the `research group - theme` relation from 1 x n to n x n
- [x] Change the `thesis project - theme` relation from 1 x n to n x n
Main UI changes:
- [x] Admin search view (Ransack associations)
- [x] Update admin theme pages
- [x] Update admin thesis project pages
- [x] Update admin research group pages
- [x] Add a way to select research groups on admin theme page
- [x] Add a way to select programmes on admin theme pagel
- [x] Add a way to select themes on admin thesis project page
- [x] Make navigation links on admin panel show pages clickable (e.g. themes of a thesis project)
- [x] Fix dashboard (normal and admin)
- [x] Update student view
Models:
- [x] There must be at least one research group associated with every theme.
- [x] Rename Theme to Topic (only in language files)
- [ ] Still needs to be done in some non-translated strings
Permissions:
- [x] Research group members should be able to make new themes.
- [x] Everyone with access to the theme should be able to link more associated users and research groups.
- [x] Associated users should have access to a theme even if they're not part of a research group. Make sure they have access to the management panel to see the theme.
- [x] Programme coordinators should be able to create themes and thesis projects
- [x] Programme coordinators should be able to access all themes and thesis projects and edit them.
- [x] Only programme coordinators should be able to edit the programme association, and only the association with their own programme.
- Add message to contact coordinator.
Tests:
- [x] Fix failing tests
- [x] Theme - research group
- [x] Theme validation (at least one research group)
- [x] Thesis project - theme
- [x] Theme - programme (programme permission checks)
- [x] Permissions
Closes #679https://gitlab.ewi.tudelft.nl/eip/projectforum/projectforum/-/merge_requests/905Draft: Activate Dutch language selection on production2023-08-19T11:48:45+02:00Martin Mladenovm.mladenov@student.tudelft.nlDraft: Activate Dutch language selection on productionTasks:
- [x] Fix bug with language notifications #565
- [ ] Finish translating user-facing views !1060
- [x] Add language selector to navbar for logged-in users !1064
- [x] Add language to registration form #698
- [x] Automatically swi...Tasks:
- [x] Fix bug with language notifications #565
- [ ] Finish translating user-facing views !1060
- [x] Add language selector to navbar for logged-in users !1064
- [x] Add language to registration form #698
- [x] Automatically switch SSO users to their preferred language
Closes #538https://gitlab.ewi.tudelft.nl/eip/projectforum/projectforum/-/merge_requests/729Draft: Improve permission checks and logic2023-01-05T13:17:04+01:00Taico Aertst.v.aerts@tudelft.nlDraft: Improve permission checks and logic* Fix rolify with_role to be combineable into larger queries without using .ids
* Add option to define rolify relations easily as has_many relations on models.
* Update associatable with the increased flexibility to let ActiveRecord comb...* Fix rolify with_role to be combineable into larger queries without using .ids
* Add option to define rolify relations easily as has_many relations on models.
* Update associatable with the increased flexibility to let ActiveRecord combine queries better.
* Make use of hashes rather than `.ids` in the ability to prevent queries on load and allow CanCanCan to do its job better
* Add extension to CanCanCan to allow joining can definitions with scopes together
TODO:
* [x] Check whether using `.select(:id)` in the ability makes better queries than the left-over `id: ....ids`.
* [ ] Check performance of new roles queries (left outer join) and determine whether its better to use scopes.
* [x] Convert more of the ability file to use scopes.
Relates to #81