diff --git a/CHANGELOG_UNRELEASED.md b/CHANGELOG_UNRELEASED.md index dc6291d3a38a63c4dde1d4a42a18aef18a0f51a4..e3a8f515be3be57f295c4457e89976786022867b 100644 --- a/CHANGELOG_UNRELEASED.md +++ b/CHANGELOG_UNRELEASED.md @@ -18,6 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/). - [Student] Move to top button on preferences triggers "Save preferences" button (#782) - [Coordinator] Fix offerer selector in management panel (#784) - [Dev] Fixed letter_opener_web version requiring ruby version not supported by the server (!1157) +- [Dev] Fix migration from first and last name to display name (!1162) ### Changed diff --git a/db/migrate/20231015150711_migrate_full_name_events.rb b/db/migrate/20231015150711_migrate_full_name_events.rb index 955601086270867802903a96bbac0a30fdfef234..aea1da1aae6cd3f8a3b696229da826e7bee141ae 100644 --- a/db/migrate/20231015150711_migrate_full_name_events.rb +++ b/db/migrate/20231015150711_migrate_full_name_events.rb @@ -1,19 +1,15 @@ class MigrateFullNameEvents < ActiveRecord::Migration[7.0] def up - Event.where('1=1').each do |event| - unless event.resource_type == Theme or event.resource_type == ThesisProject or event.resource_type == Project - return - end - + Event.where(resource_type: [Theme, ThesisProject, Project]).each do |event| msg_params = event.message_parameters new_params = {} first_name_candidate = nil last_name_candidate = nil msg_params.each do |key, value| - if key.equal?('student_firstname') + if key.to_s == 'student_firstname' first_name_candidate = value - elsif key.equal?('student_lastname') + elsif key.to_s == 'student_lastname' last_name_candidate = value else new_params[key] = value @@ -21,7 +17,7 @@ class MigrateFullNameEvents < ActiveRecord::Migration[7.0] end if first_name_candidate.present? || last_name_candidate.present? - new_params['student_displayname'] = [first_name_candidate, last_name_candidate].join(' ').strip + new_params[:student_displayname] = [first_name_candidate, last_name_candidate].join(' ').strip event.update_attribute(:message_parameters, new_params) end end