Skip to content
Snippets Groups Projects

Docker resuscitation

Merged
Ewoud Ruighaverrequested to merge
docker-resuscitation into development
All threads resolved!

Description

Revives the docker runner.

Changes

  • Changed the docker api address to support running in the k8s cluster
  • Re-introduced some features needed by docker (most notably the job options)

Additions

Test and Review

To be filled in by the reviewers

  • All of the methods are commented to expectation

  • The methods are tested to satisfaction

  • There are no unnecessary files present in the MR

  • The continuous integration has no problems with the MR

  • The MR is filled in as requested (including labels, milestones, and reviewers)

  • The documentation is up-to-date

  • All nullable parameters are marked as such

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tim van der Horst
  • Tim van der Horst
  • added 1 commit

    Compare with previous version

  • Ewoud Ruighaver resolved all discussions

    resolved all discussions

  • added 1 commit

    • 53c3293f - Move the docker api address to the worker settings

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Luc Everse approved this merge request

    approved this merge request

  • added 1 commit

    Compare with previous version

  • Tim van der Horst approved this merge request

    approved this merge request

  • Luc Everse approved this merge request

    approved this merge request

  • Luc Everse enabled an automatic merge when the pipeline for 3ba141bc succeeds

    enabled an automatic merge when the pipeline for 3ba141bc succeeds

  • merged

  • Luc Everse mentioned in commit acdb4e8b

    mentioned in commit acdb4e8b

  • Please register or sign in to reply
    Loading