Skip to content

SIG refactoring

Tim van der Horst requested to merge SIG-refactoring into development

Description

Refactor methods to reduce parameter count so SIG complains less.

As discussed by the team, other methods with a method length >=50 and parameter count >=5 will be left as is. Most high parameter counts are due to dependency injection, and would require major refactoring to reduce this parameter count. It would also probably have a negative effect on the testability of these classes.

Changes

Change constructor for PyLintResult. Add model validation to CPMController Refactor CPMController::uploadAction Fix PyLint not being able to parse json message-id field.

Additions

Add CPM data model, which is verified by spring.

Test and Review

To be filled in by the reviewers

  • All of the methods are commented to expectation

  • The methods are tested to satisfaction

  • There are no unnecessary files present in the MR

  • The continuous integration has no problems with the MR

  • The MR is filled in as requested (including labels, milestones, and reviewers)

  • The documentation is up-to-date

  • All nullable parameters are marked as such

Edited by Tim van der Horst

Merge request reports