More template updates

Description

Updates the merge request templates with the changes discussed today.

Changes

• Renamed PR to MR

• Removed the @Nullable requirement since we cannot adopt this cleanly: JSR 305 has been dormant since May 2012, and since it is not part of the specification, any implementation following the specification is in violation of the Oracle JRE binary license Meanwhile, CheckerFramework is having trouble adopting Java 9, let alone 11. What remains are annotation providers that do not allow for package-wide defaults, which means that every NotNull parameter must be declared as such. I have not counted the parameters in the entire codebase, but I expect this to be an impressive number.

  Update: JRE 11 is now shipped under GPLv2+CPE, so the JSR 305 classes can be used without incurring the wrath of Oracle. I will reinstate the requirement for code-based MRs and submit an MR annotating the codebase soon. See issue #130 (closed).

• Reworded the checkbox descriptions somewhat to reflect the new features and slightly improve grammar I'm not sure?

Additions

• A no-code template for merge requests that do not add or change code (like API documentation updates, for example)

Test and Review

To be filled in by the reviewers

• There are no unnecessary files present in the MR

• The continuous integration has no problems with the MR

• The MR is filled in as requested (including labels, milestones, and reviewers)

• The documentation is up-to-date

.gitlab/merge_request_templates/default.md

@@ -22,11 +22,11 @@
 
 - [ ] The methods are tested to satisfaction
 
-- [ ] There are no unnecessary files added to the PR
+- [ ] There are no unnecessary files present in the MR
 
-- [ ] The continuous integration has no problems with the PR
+- [ ] The continuous integration has no problems with the MR
 
-- [ ] The PR is filled in as requested e.g. labels added reviews requested
+- [ ] The MR is filled in as requested (including labels, milestones, and reviewers)
 
 - [ ] The documentation is up-to-date