Skip to content
Snippets Groups Projects

Feedback hiding

Merged
Luc Everserequested to merge
feedback-hiding into development
1 open thread

Description

Adds authorization levels for feedback. This is to limit the details of feedback given to students, while allowing the TAs to see the full report. See eip/labrador/auta/auta-script-runtime-facade!1 for details on the model.

Resolves #227 (closed)

Changes

  • Reports vary by the authorization level of the current user
  • Errors are included in the report iff the user is an admin
  • Spring auth roles are mapped to authorization levels globally, so these can be used for other purposes as well (and this is intended, resolving #184 (closed))
  • A builder for AutaUsers as the constructor was getting out of hand
  • A fix for CommentCounterGeneric returing integer percentages, while the metric type expected doubles. This was slowing down metric processing

Test and Review

To be filled in by the reviewers

  • All of the methods are commented to expectation

  • The methods are tested to satisfaction

  • There are no unnecessary files present in the MR

  • The continuous integration has no problems with the MR

  • The MR is filled in as requested (including labels, milestones, and reviewers)

  • The documentation is up-to-date

  • All nullable parameters are marked as such

Edited by Erik Oudsen

Merge request reports

Pipeline #221875 passed with warnings

Pipeline passed with warnings for 86a6a3c7 on feedback-hiding

Approval is optional

Merged by Erik OudsenErik Oudsen Oct 14, 2019 (Oct 14, 2019 12:40pm UTC)

Merge details

Pipeline #221991 passed

Pipeline passed for 7bec0870 on development

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading