Feedback hiding
Description
Adds authorization levels for feedback. This is to limit the details of feedback given to students, while allowing the TAs to see the full report. See eip/labrador/auta/auta-script-runtime-facade!1 for details on the model.
Resolves #227 (closed)
Changes
- Reports vary by the authorization level of the current user
- Errors are included in the report iff the user is an admin
- Spring auth roles are mapped to authorization levels globally, so these can be used for other purposes as well (and this is intended, resolving #184 (closed))
- A builder for AutaUsers as the constructor was getting out of hand
- A fix for CommentCounterGeneric returing integer percentages, while the metric type expected doubles. This was slowing down metric processing
Test and Review
To be filled in by the reviewers
-
All of the methods are commented to expectation -
The methods are tested to satisfaction -
There are no unnecessary files present in the MR -
The continuous integration has no problems with the MR -
The MR is filled in as requested (including labels, milestones, and reviewers) -
The documentation is up-to-date -
All nullable parameters are marked as such
Merge request reports
Activity
changed milestone to %Queue 1.0
added 11 commits
- 5d2ba12e - Document SamlAssertionConsumer
- 2451e84f - Move @Nullable to its own line
- 9cdbaacb - Fix formatting
- 75fbd797 - Document getSigningCredential
- d1956c43 - Less space
- e48812b0 - Out with the space, in with the space
- e5e2c951 - Fix constructor javadoc
- 09c9ac9c - Scratch an itch and remove snakes
- d16e2386 - Document feature disabled exceptions
- 16165d0c - Make vars final where possible
- 63e497d3 - Merge branch 'sso' into feedback-hiding
Toggle commit listadded 1 commit
- 8c696d89 - Implement authorization-based report filtering
added 2 commits
added 2 commits
mentioned in merge request !132 (merged)
added 25 commits
-
14966823...7fdc1a02 - 12 commits from branch
development
- 4499d67e - Merge branch 'development' into sso
- 31b82f96 - Merge branch 'development' into sso
- 0d6c1906 - Remove ~kebab~ saml
- 959c31de - Remove test resources
- 14f4c693 - Remove Wess dance
- fb6adc93 - Remove SAML settings
- 48705b01 - Remove default SAML values
- 824964fa - Remove SAML templates
- f1f9088f - Remove test.log
- f9b61069 - Remove schemas
- f9152197 - Remove API docs for SAML endpoints
- 04fba68e - Merge branch 'auth-fw-refactor' into feedback-hiding
- 1325868b - Fix unit testing and CPM tests with the new user type
Toggle commit list-
14966823...7fdc1a02 - 12 commits from branch
added 7 commits
-
1325868b...5aaab3f6 - 6 commits from branch
development
- c760fe4f - Merge branch 'development' into feedback-hiding
-
1325868b...5aaab3f6 - 6 commits from branch
mentioned in issue #229 (closed)
added 4 commits
Toggle commit listmentioned in commit 7bec0870
unassigned @leverse