Skip to content

Feedback hiding

Luc Everse requested to merge feedback-hiding into development

Description

Adds authorization levels for feedback. This is to limit the details of feedback given to students, while allowing the TAs to see the full report. See eip/labrador/auta/auta-script-runtime-facade!1 for details on the model.

Resolves #227 (closed)

Changes

  • Reports vary by the authorization level of the current user
  • Errors are included in the report iff the user is an admin
  • Spring auth roles are mapped to authorization levels globally, so these can be used for other purposes as well (and this is intended, resolving #184 (closed))
  • A builder for AutaUsers as the constructor was getting out of hand
  • A fix for CommentCounterGeneric returing integer percentages, while the metric type expected doubles. This was slowing down metric processing

Test and Review

To be filled in by the reviewers

  • All of the methods are commented to expectation

  • The methods are tested to satisfaction

  • There are no unnecessary files present in the MR

  • The continuous integration has no problems with the MR

  • The MR is filled in as requested (including labels, milestones, and reviewers)

  • The documentation is up-to-date

  • All nullable parameters are marked as such

Edited by Erik Oudsen

Merge request reports