Skip to content
Snippets Groups Projects

Make displacements optional in mem refs

Description

Fixes a shortcoming in the AT&T assembly syntax that required complex memory references to always have a displacement.

Changes

  • Allowed multiple sub-expressions within a parenthesized expression.

Additions

None.

Test and Review

To be filled in by the reviewers

  • All of the methods are commented to expectation

  • The methods are tested to satisfaction

  • There are no unnecessary files present in the MR

  • The continuous integration has no problems with the MR

  • The MR is filled in as requested (including labels, milestones, and reviewers)

  • The documentation is up-to-date

  • All nullable parameters are marked as such

Merge request reports

Pipeline #375967 passed with warnings

Pipeline passed with warnings for 6c537ec8 on asm-optional-disp

Approval is optional

Merged by Luc EverseLuc Everse Sep 28, 2020 (Sep 28, 2020 11:05am UTC)

Merge details

  • Changes merged into with 5465463d.
  • Did not delete the source branch.
  • Auto-merge enabled

Pipeline #375969 passed with warnings

Pipeline passed with warnings for 5465463d on development

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading