Check for identity before identifier param in direct-upload

Description

Adds the identity param in addition to the old identifier for better API compliance.

The old parameter is still supported, but identity has precedence.

Changes

• identifier is now only used if identity is not present

Additions

• the identity parameter

Test and Review

Resolves #254 (closed)

To be filled in by the reviewers

• All of the methods are commented to expectation

• The methods are tested to satisfaction

• There are no unnecessary files present in the MR

• The continuous integration has no problems with the MR

• The MR is filled in as requested (including labels, milestones, and reviewers)

• The documentation is up-to-date

• All nullable parameters are marked as such

core/src/main/java/nl/tudelft/ewi/auta/core/controller/SubmissionController.java

@@ -376,12 +376,21 @@ public class SubmissionController extends ControllerBase {
             final @PathVariable String aid,
             final @RequestParam(value = "file") MultipartFile file,
             final @RequestParam String directUploadId,
+            final @Nullable @RequestParam(value = "identity", required = false) String reqIdentity,
             final @Nullable @RequestParam(value = "identifier", required = false) String identifier
     ) throws IOException, URISyntaxException {
+        @Nullable
+        final String identity;
+        if (reqIdentity != null) {
+            identity = reqIdentity;
+        } else {
+            identity = identifier;
+        }
+
         final var res = new Response();
         //final var commit = this.getString(req, "commit", res);
-        logger.debug("Received trampoline message, assignment id {}, directUploadId {}, "
-                        + "identifier {}", aid, directUploadId, identifier);
+        logger.debug("Received direct upload, assignment id {}, directUploadId {}, "
+                        + "identity {}", aid, directUploadId, identity);
 
         // Check if the original filename has an extension
         final var originalFilename = file.getOriginalFilename();
@@ -420,12 +429,12 @@ public class SubmissionController extends ControllerBase {
         assignment = assignmentRepository.save(assignment);
         logger.debug("Created new submission for direct-upload submission, submission id {}", sid);
 
-        if (identifier == null) {
+        if (identity == null) {
             logger.warn("Submission id {} does not belong to an identity", sid);
         } else {
-            final var identityContainer = new IdentityContainer(sid, identifier);
+            final var identityContainer = new IdentityContainer(sid, identity);
             this.repositories.getIdentityRepository().save(identityContainer);
-            logger.debug("Submission id {} belongs to {}", sid, identifier);
+            logger.debug("Submission id {} belongs to {}", sid, identity);
         }
 
         this.queue.add(new Job(assignment, submission));