Skip to content
Snippets Groups Projects

Worker management overhaul

Description

In line with the new worker management design, the workers and core have been reworked. Resolves #121 (closed) #125 (closed) #124 (closed)

Changes

  • Removed the local worker spawner
  • Workers are now exclusively single-threaded

Additions

  • The core reports the number of workers in the ping debug message
  • Workers report to the core if they've been terminated, so they are properly removed from the pool
  • Worker docker image
  • Added endpoint to retrieve a worker token, since after removing the local worker spawner this would not have been possible otherwise.

Test and Review

  • Tested the new API endpoint

To be filled in by the reviewers

  • All of the methods are commented to expectation

  • The methods are tested to satisfaction

  • There are no unnecessary files present in the MR

  • The continuous integration has no problems with the MR

  • The MR is filled in as requested (including labels, milestones, and reviewers)

  • The documentation is up-to-date

  • All nullable parameters are marked as such

Edited by Erik Oudsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Luc Everse
  • 9 import java.util.Arrays;
    10 import java.util.stream.Collectors;
    11
    12 import org.slf4j.Logger;
    13 import org.slf4j.LoggerFactory;
    14 import org.springframework.stereotype.Service;
    15
    16 import nl.tudelft.ewi.auta.core.authentication.DatabaseConnector;
    17 import nl.tudelft.ewi.auta.core.authentication.TokenGenerator;
    18 import nl.tudelft.ewi.auta.core.settings.GlobalSettings;
    19
    20 /**
    21 * Spawns a new worker on the local machine.
    22 */
    23 @Service
    24 public class LocalWorkerSpawner implements WorkerSpawner {
  • Ewoud Ruighaver marked the checklist item All nullable parameters are marked as such as incomplete

    marked the checklist item All nullable parameters are marked as such as incomplete

  • Ewoud Ruighaver marked the checklist item The documentation is up-to-date as incomplete

    marked the checklist item The documentation is up-to-date as incomplete

  • Ewoud Ruighaver marked the checklist item The MR is filled in as requested (including labels, milestones, and reviewers) as incomplete

    marked the checklist item The MR is filled in as requested (including labels, milestones, and reviewers) as incomplete

  • Ewoud Ruighaver marked the checklist item The continuous integration has no problems with the MR as incomplete

    marked the checklist item The continuous integration has no problems with the MR as incomplete

  • Ewoud Ruighaver marked the checklist item There are no unnecessary files present in the MR as incomplete

    marked the checklist item There are no unnecessary files present in the MR as incomplete

  • Ewoud Ruighaver marked the checklist item All of the methods are commented to expectation as incomplete

    marked the checklist item All of the methods are commented to expectation as incomplete

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading