Enforce assignment timeouts from the core

Description

Adds an extra layer of timeout enforcement, this time by the core. While workers should be able to control themselves and quit if the timeout is exceeded, under some conditions this does not happen. With this fix, the core will keep track of the time and instruct the worker to terminate if it exceeded the timeout (20%).

Changes

• Fix the REST exception handler sending content types including stars (*)
• Fix the assignment controller erasing existing timeout values if the PUT request did not contain a timeout
  • The old behavior is arguably what the HTTP spec says should happen, but aside from hand-crafting requests to set the timeout correctly there is no good way to preserve timeouts with the current UI

Additions

• Send a kill command if the worker has had the same job for longer than the timeout allowed

Test and Review

To be filled in by the reviewers

• All of the methods are commented to expectation

• The methods are tested to satisfaction

• There are no unnecessary files present in the MR

• The continuous integration has no problems with the MR

• The MR is filled in as requested (including labels, milestones, and reviewers)

• The documentation is up-to-date

• All nullable parameters are marked as such

core/src/main/java/nl/tudelft/ewi/auta/core/communication/MessageReceiver.java

@@ -18,6 +18,7 @@ import nl.tudelft.ewi.auta.common.communication.ServerCommunicationException;
 import nl.tudelft.ewi.auta.common.threads.Threads;
 import nl.tudelft.ewi.auta.core.database.EntityContainer;
 import nl.tudelft.ewi.auta.core.database.SubmissionRepository;
+import nl.tudelft.ewi.auta.core.model.Job;
 import nl.tudelft.ewi.auta.core.settings.GlobalSettings;
 import nl.tudelft.ewi.auta.core.settings.SettingKey;
 import org.slf4j.Logger;
@@ -266,34 +267,27 @@ public class MessageReceiver {
             return;
         }
 
+        @Nullable
+        final var job = worker.getCurrentJob();
+
         switch (message.getType()) {
             case "bye":
                 logger.info("Worker {} shutting down", worker);
+
+                if (job != null) {
+                    this.cancelJob(worker, job, message);
+                }
+
                 this.pool.eject(worker);
                 break;
 
             case "exception":
-                final var job = worker.getCurrentJob();
                 if (job != null) {
                     logger.warn("Submission caused an uncaught exception in worker {}", worker);
                     logger.warn("{}", message.getData());
 
-                    var exceptionMessage = (String) message.getData();
-                    final var submission = job.getSubmission();
-
-                    final var fakeResults = new EntityContainer(
-                            new ProjectEntity(),
-                            submission.getId(),
-                            true,
-                            exceptionMessage,
-                            submission.getAssignmentId()
-                    );
-
-                    submission.getPipelineLog().setAnalysisDone(Instant.now());
-                    this.submissionRepository.save(submission);
+                    this.cancelJob(worker, job, message);
 
-                    this.resultsProcessor.process(fakeResults);
-                    worker.setCurrentJob(null);
                     this.pool.dismiss(worker);
                 } else {
                     logger.warn("Idle worker {} reported exception {}", worker, message.getData());
@@ -327,6 +321,34 @@ public class MessageReceiver {
         }
     }
 
+    /**
+     * Cancels a job via a message.
+     *
+     * @param worker the worker the job was assigned to
+     * @param message the message that triggered the cancelation
+     * @param job the job to cancel
+     */
+    private void cancelJob(final WorkerConnection worker, final Job job, final Message message) {
+        worker.setCurrentJob(null);
+
+        @Nullable
+        var exceptionMessage = (String) message.getData();
+        final var submission = job.getSubmission();
+
+        final var fakeResults = new EntityContainer(
+                new ProjectEntity(),
+                submission.getId(),
+                true,
+                exceptionMessage,
+                submission.getAssignmentId()
+        );
+
+        submission.getPipelineLog().setAnalysisDone(Instant.now());
+        this.submissionRepository.save(submission);
+
+        this.resultsProcessor.process(fakeResults);
+    }
+
     /**
      * Handles a ping response command ("polo").
      *