Skip to content
Snippets Groups Projects

Fix the worker run test

Description

Fixes the worker#run test failing sometimes because of race conditions.

Changes

Changes the worker test so it mocks out threading.

Additions

Adds a new method to the Threads helper that spawns un-managed threads.

Test and Review

To be filled in by the reviewers

  • All of the methods are commented to expectation

  • The methods are tested to satisfaction

  • There are no unnecessary files present in the MR

  • The continuous integration has no problems with the MR

  • The MR is filled in as requested (including labels, milestones, and reviewers)

  • The documentation is up-to-date

  • All nullable parameters are marked as such

Edited by Erik Oudsen

Merge request reports

Pipeline #155283 passed

Pipeline passed for 3b85b5c7 on fix-worker-run-test

Approval is optional

Merged by Ewoud RuighaverEwoud Ruighaver May 8, 2019 (May 8, 2019 10:35am UTC)

Merge details

  • Changes merged into development with 3fccbd8c.
  • Deleted the source branch.

Pipeline #155444 passed

Pipeline passed for 3fccbd8c on development

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Luc Everse added priocritical typebug + 1 deleted label

    added priocritical typebug + 1 deleted label

  • Erik Oudsen marked the checklist item All of the methods are commented to expectation as completed

    marked the checklist item All of the methods are commented to expectation as completed

  • Erik Oudsen marked the checklist item The methods are tested to satisfaction as completed

    marked the checklist item The methods are tested to satisfaction as completed

  • Erik Oudsen marked the checklist item There are no unnecessary files present in the MR as completed

    marked the checklist item There are no unnecessary files present in the MR as completed

  • Erik Oudsen marked the checklist item The MR is filled in as requested (including labels, milestones, and reviewers) as completed

    marked the checklist item The MR is filled in as requested (including labels, milestones, and reviewers) as completed

  • Erik Oudsen marked the checklist item All nullable parameters are marked as such as completed

    marked the checklist item All nullable parameters are marked as such as completed

  • Erik Oudsen marked the checklist item The continuous integration has no problems with the MR as completed

    marked the checklist item The continuous integration has no problems with the MR as completed

  • Erik Oudsen marked the checklist item The documentation is up-to-date as completed

    marked the checklist item The documentation is up-to-date as completed

  • Erik Oudsen approved this merge request

    approved this merge request

  • Ewoud Ruighaver approved this merge request

    approved this merge request

  • Ewoud Ruighaver mentioned in commit 3fccbd8c

    mentioned in commit 3fccbd8c

  • Luc Everse mentioned in merge request !19 (merged)

    mentioned in merge request !19 (merged)

Please register or sign in to reply
Loading