Skip to content
Snippets Groups Projects

Add a checkstyle job to the CI pipeline

Description

Reintroduces Checkstyle to the continuous integration pipeline. The herokuish buildpack only runs tests, so we had a lot of unexpected failures locally.

Changes

None

Additions

  • A checkstyle job in the review stage. It is not allowed to fail. In a separate stage so you have to wait just to annoy @eoudsen

Test and Review

To be filled in by the reviewers

  • There are no unnecessary files present in the MR

  • The continuous integration has no problems with the MR

  • The MR is filled in as requested (including labels, milestones, and reviewers)

  • The documentation is up-to-date

Edited by Tim van der Horst

Merge request reports

Pipeline #157290 passed

Pipeline passed for 93f38628 on checkstyle-in-ci

Approval is optional

Merged by Tim van der HorstTim van der Horst May 10, 2019 (May 10, 2019 7:59am UTC)

Merge details

  • Changes merged into development with 98a1b762.
  • Deleted the source branch.

Pipeline #157328 passed

Pipeline passed for 98a1b762 on development

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading