Skip to content
Snippets Groups Projects

Verdict passing

Merged Verdict passing
verdict into development
1 open thread
Merged
Erik Oudsenrequested to merge
verdict into development
1 open thread

Description

Adds verdict passing back into the report generator.
Now a maximum amount of failures and warnings can be added for each specific metric and the project overall.
This is part of #106 (closed) The UI requires updates for this issue to be closed.

Changes

Metric settings now contain the two maximum values for warnings and failures, so do assignment. The report generator now also generates a verdict. The project entity has a new verdict field.

Additions

Verdict passing

Test and Review

To be filled in by the reviewers

  • All of the methods are commented to expectation

  • The methods are tested to satisfaction

  • There are no unnecessary files present in the MR

  • The continuous integration has no problems with the MR

  • The MR is filled in as requested (including labels, milestones, and reviewers)

  • The documentation is up-to-date

  • All nullable parameters are marked as such

Edited by Luc Everse

Merge request reports

Pipeline #172857 passed

Stage: build
Stage: test
Stage: review

Pipeline passed for 2dbb37b6 on verdict

Merged by Ewoud RuighaverEwoud Ruighaver May 27, 2019 (May 27, 2019 8:08am UTC)

Loading

Pipeline #173589 passed

Stage: build
Stage: test
Stage: review

Pipeline passed for 1bbca898 on development

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Luc Everse
  • Luc Everse
  • Luc Everse
  • Luc Everse
  • Luc Everse
    Luc Everse @leverse
    Contributor

    Also needs tests

  • Erik Oudsen added 1 commit

    added 1 commit

    Compare with previous version

  • Erik Oudsen marked as a Work In Progress

    marked as a Work In Progress

  • Erik Oudsen changed the description

    changed the description

  • Erik Oudsen added 1 commit

    added 1 commit

    • 9ed321a7 - Test the tests if you need more test than tests are to be tested

    Compare with previous version

  • Erik Oudsen resolved all discussions

    resolved all discussions

  • Erik Oudsen added 6 commits

    added 6 commits

    Compare with previous version

  • Erik Oudsen unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Luc Everse approved this merge request

    approved this merge request

  • Luc Everse marked the checklist item The methods are tested to satisfaction as completed

    marked the checklist item The methods are tested to satisfaction as completed

  • Luc Everse marked the checklist item All of the methods are commented to expectation as completed

    marked the checklist item All of the methods are commented to expectation as completed

  • Luc Everse marked the checklist item The continuous integration has no problems with the MR as completed

    marked the checklist item The continuous integration has no problems with the MR as completed

  • Luc Everse marked the checklist item The MR is filled in as requested (including labels, milestones, and reviewers) as completed

    marked the checklist item The MR is filled in as requested (including labels, milestones, and reviewers) as completed

  • Luc Everse marked the checklist item All nullable parameters are marked as such as completed

    marked the checklist item All nullable parameters are marked as such as completed

  • Ewoud Ruighaver approved this merge request

    approved this merge request

  • Ewoud Ruighaver merged

    merged

  • Ewoud Ruighaver mentioned in commit 1bbca898

    mentioned in commit 1bbca898

  • Otto Visser unassigned @eoudsen

    unassigned @eoudsen

    • Please register or sign in to reply