Fix SpotBugs

Merged Luc Everse requested to merge spot-this into development


So it turned out SpotBugs only ran on the common source, which is very simple and does not have many opportunities for bugs. The rest of the project has, though, so this branch attempts to fix it all.


See the list of commits, they're very granular.


SpotBugs tasks for all projects, not just the root project.

Test and Review

To be filled in by the reviewers

  • All of the methods are commented to expectation

  • The methods are tested to satisfaction

  • There are no unnecessary files present in the MR

  • The continuous integration has no problems with the MR

  • The MR is filled in as requested (including labels, milestones, and reviewers)

  • The documentation is up-to-date

  • All nullable parameters are marked as such

Edited by Luc Everse

Merge request reports