Skip to content

Benchmarking reports hotfix

Tim van der Horst requested to merge benchmarking-reports-hotfix into development

Description

Closes #181 (closed), #180 (closed) This fixes a few bugs in the core and workers, which caused docmon to stop working due to workers crashing.

Changes

As issue #155 (closed) is not yet resolved, aggregating entities for benchmarking caused a MissingMetricException to be raised when Lizard and CK run together as the names do not match, which meant some entities did not contain the CYCLOMATIC_COMPLEXITY metric.

Additions

  • Added more debug and trace statements used while diagnosing the bug.
  • Made sure CK actually deletes temp files, used to delete in the wrong order.
  • Catch ParseExceptions in JobSplitter, which occurred when invalid java files were parsed and caused the worker to crash

Test and Review

To be filled in by the reviewers

  • All of the methods are commented to expectation

  • The methods are tested to satisfaction

  • There are no unnecessary files present in the MR

  • The continuous integration has no problems with the MR

  • The MR is filled in as requested (including labels, milestones, and reviewers)

  • The documentation is up-to-date

  • All nullable parameters are marked as such

Edited by Tim van der Horst

Merge request reports