Skip to content
Snippets Groups Projects

Course initial

Merged
Tim van der Horstrequested to merge
course-initial into development
All threads resolved!

Description

Closes #187 (closed), #183 (closed) A working backend support for courses. This includes a new repository and controller which manages the courses.

A course has the following structure (when serialized):

{
    "id": "5cf028357fc2582206be877b",
    "name": "Complexity Theory",
    "courseCode": "TI3306",
    "year": 2019,
    "instructorSet": [],
    "taSet": [
        "ta"
    ],
    "assignmentIds": [
        "5ce653c5ff1dbf1ab679583d"
    ]
} 

The following actions can be performed

  • Retrieve the list of all courses
  • Add a new course
  • Add an assignment to a course
  • Add a user to a course (with proper authentication)

Changes

  • Refactored the getUser method to return an optional
  • General refactoring of the DatabaseConnection to not throw more sensible exceptions (e.g. when a user cannot be found)

Additions

  • A CourseRepository, Course and CourseController

Test and Review

To be filled in by the reviewers

  • All of the methods are commented to expectation

  • The methods are tested to satisfaction

  • There are no unnecessary files present in the MR

  • The continuous integration has no problems with the MR

  • The MR is filled in as requested (including labels, milestones, and reviewers)

  • The documentation is up-to-date

  • All nullable parameters are marked as such

Edited by Tim van der Horst

Merge request reports

Pipeline #181661 passed

Pipeline passed for 996da2a5 on course-initial

Approval is optional

Merged by Erik OudsenErik Oudsen Jun 4, 2019 (Jun 4, 2019 8:21am UTC)

Merge details

Pipeline #181761 passed

Pipeline passed for de22a93f on development

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Luc Everse
  • Luc Everse
  • Luc Everse
  • Luc Everse
  • Luc Everse
  • Luc Everse
  • Tim van der Horst added 138 commits

    added 138 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 22 commits

    Compare with previous version

  • Tim van der Horst resolved all discussions

    resolved all discussions

  • Luc Everse approved this merge request

    approved this merge request

  • Luc Everse unapproved this merge request

    unapproved this merge request

  • Tim van der Horst marked as a Work In Progress

    marked as a Work In Progress

  • added 1 commit

    • ad4835fc - Fix secured methods not working by moving to secured service.

    Compare with previous version

  • Tim van der Horst added 18 commits

    added 18 commits

    Compare with previous version

  • Tim van der Horst unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Tim van der Horst resolved all discussions

    resolved all discussions

  • Luc Everse approved this merge request

    approved this merge request

  • Tim van der Horst added 28 commits

    added 28 commits

    Compare with previous version

  • Luc Everse approved this merge request

    approved this merge request

  • Erik Oudsen approved this merge request

    approved this merge request

  • Erik Oudsen mentioned in commit de22a93f

    mentioned in commit de22a93f

  • merged

  • Please register or sign in to reply
    Loading