Skip to content

Everything is nonnull

Luc Everse requested to merge everything-is-nonnull into development

Description

Extends the reach of non-null to everything ever.

Additions

  • A new Annotation applying @Nonnull to packages, fields, local variables, methods, parameters, and field usage

Changes

  • Applied the much more strict annotation to all packages
  • What can be null, is nullable
  • Removed everything Report as it was causing errors and it was too much effort to fix
  • Fixed some logic in places where initalization was not detected properly by SpotBugs
  • Fixed some hashmap not being an enum map that was causing problems for reasons unknown
  • Upgraded to the brand-spanking-new Spotbugs plugin v2
  • Accidentally hit reformat in some classes, can't be arsed to fix it so deal with it

Test and Review

To be filled in by the reviewers

  • All of the methods are commented to expectation

  • The methods are tested to satisfaction

  • There are no unnecessary files present in the MR

  • The continuous integration has no problems with the MR

  • The MR is filled in as requested (including labels, milestones, and reviewers)

  • The documentation is up-to-date

  • All nullable parameters are marked as such

Edited by Erik Oudsen

Merge request reports