Skip to content

∗untars∗

Luc Everse requested to merge ∗untars∗ into development

Description

Yeah you're reading this right, it's back

Looking at parameter grammars all day is not good for the spirit and having a stab at SSO would be a step in the wrong direction. Instead, a common-cold-fueled (yes, again) bout of programming gave rise to this MR, which introduces support for tar-based archives. 7z is also a possible future addition. rar will require extra libraries and I'm not sure about the licensing restrictions around the format so I hope nobody is going to pull an Erik at some point (but I'm sure it will happen)

Changes

  • JobUnzipper is dead, long live Unpacker! About a week after its birth, JobUnzipper was already used to unzip Lizard as well so a name change was needed
  • Likewise, MaliciousZipException has been rebranded as the more format-neutral MaliciousArchiveException
  • The tests are back and better than ever. It no longer attempts to download zips from broken URLs

Additions

  • Support for tar (.tar) and various compressors: gzip (.tar.gz, .tgz, .tpz), bzip2 (.tar.bz2, .tar.bzip2, .tbz, .tbz2, .tb2), LZMA (.tar.lzma, .tlz, .tlzma), xz (.tar.xz, .txz), and compress (.tar.Z, .tZ)
  • Test archives for most formats and some error cases. The contents are not meant to be seen and may incur insanity in those who look upon them

Test and Review

To be filled in by the reviewers

  • All of the methods are commented to expectation

  • The methods are tested to satisfaction

  • There are no unnecessary files present in the MR

  • The continuous integration has no problems with the MR

  • The MR is filled in as requested (including labels, milestones, and reviewers)

  • The documentation is up-to-date

  • All nullable parameters are marked as such

Merge request reports