Fix the loading time of puzzle list
This merge request should improve the performance of the puzzle list page on Pupple. It is ensured in two ways:
- The controller no longer fetches the list of all puzzles from the database, but only a portion of the data that is displayed on the given page (i.e. 14 rows instead of 150 and going up)
- Non-blocking calls using
puzzleAttemptService
are no longer blocked in a loop (which defeated the whole purpose of having them non-blocking), nowMono.when
is used instead to wait for all tasks to finish simultaneously.
Furthermore a DTO is used, which might improve performance, but not as significantly.
I've checked the changes manually and they seem to not break anything while (potentially) improving performance.
Changelog:
## [0.0.4]
### Added
### Changed
- Pass a single DTO instead of multiple HashMap inside PuzzleList.html ( @cbaraya)
- Fetch only the puzzles from the database that will be used ( @kradziwilowicz)
### Fixed
- Made retrieving display names no longer block to increase performance ( @kradziwilowicz)
Edited by Christiaan Baraya
Merge request reports
Activity
added priohigh label
added 9 commits
-
5fe5b906...5e3deed0 - 4 commits from branch
development
- 48ac72aa - Might fix the load time on puzzle overview
- 94555309 - Use a dataobject instead for the all puzzles overview
- d54fdf04 - Also used a data object for the profile page
- f21df22d - Removed the creator collumn from profiles, since it is redundant
- 4e7ae1ba - Fix the loading time of puzzle list
Toggle commit list-
5fe5b906...5e3deed0 - 4 commits from branch
enabled an automatic merge when the pipeline for 4e7ae1ba succeeds
mentioned in commit bce3d1a0
Please register or sign in to reply