Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
P
Pupple
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
EIP
Labrador
Pupple
Merge requests
!7
Fix
#3
: trim the puzzle guess and the solution before comparing them
Code
Review changes
Check out branch
Open in Workspace
Download
Patches
Plain diff
Expand sidebar
Merged
Fix
#3
: trim the puzzle guess and the solution before comparing them
fix-puzzle-attempt-not-trimmed
into
development
Overview
0
Commits
1
Pipelines
2
Changes
1
Merged
Fix #3: trim the puzzle guess and the solution before comparing them
Ksawery Radziwiłowicz
requested to merge
fix-puzzle-attempt-not-trimmed
into
development
Sep 27, 2023
Overview
0
Commits
1
Pipelines
2
Changes
1
Description
The user's guess and puzzle's solution are now trimmed before being compared.
Checklist
I have added tests for functionality I added and/or changed
I have changed the database schema
I have added migrations
I have added the required changelog entries
I have run my branch and ensured all functionality is still working as intended
Closes
#3 (closed)
0
0
Merge request reports
Compare
development
development (base)
and
latest version
latest version
bd530ea4
1 commit,
Sep 27, 2023
1 file
+
1
−
1
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
src/main/java/nl/tudelft/pupple/service/PuzzleAttemptService.java
+
1
−
1
View file @ bd530ea4
Edit in single-file editor
Open in Web IDE
Show full file
@@ -67,7 +67,7 @@ public class PuzzleAttemptService {
guessObject
=
guessRepository
.
save
(
guessObject
);
attempt
.
getGuesses
().
add
(
guessObject
);
if
(
attempt
.
getPuzzle
().
getSolution
().
t
oLowerCase
().
equals
(
guess
.
toLowerCase
()))
{
if
(
attempt
.
getPuzzle
().
getSolution
().
t
rim
().
equalsIgnoreCase
(
guess
.
trim
()))
{
attempt
.
setSolved
(
true
);
}
puzzleAttemptRepository
.
save
(
attempt
);
Loading