Skip to content
Snippets Groups Projects
Commit 12991f1c authored by Henry Page's avatar Henry Page :speech_balloon:
Browse files

ruben suggestions

parent fd708f7c
No related branches found
No related tags found
2 merge requests!664Version 2.1.4,!654Resolve "Cascade soft delete of core entities to queue"
...@@ -15,10 +15,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ...@@ -15,10 +15,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed ### Changed
### Fixed ### Fixed
- Requests are now deleted when the corresponding lab is deleted. [@hpage](https://gitlab.ewi.tudelft.nl/hpage) - Requests are now soft-deleted when the corresponding lab is deleted. [@hpage](https://gitlab.ewi.tudelft.nl/hpage)
### Deprecated ### Deprecated
- Deprecated cache calls were removed and replaced with newer ones. [@hpage](https://gitlab.ewi.tudelft.nl/hpage)
### Removed ### Removed
......
...@@ -49,6 +49,7 @@ import org.hibernate.validator.constraints.UniqueElements; ...@@ -49,6 +49,7 @@ import org.hibernate.validator.constraints.UniqueElements;
@Inheritance(strategy = InheritanceType.JOINED) @Inheritance(strategy = InheritanceType.JOINED)
@SQLDelete(sql = "UPDATE queue_session SET deleted_at = NOW() WHERE id = ?") @SQLDelete(sql = "UPDATE queue_session SET deleted_at = NOW() WHERE id = ?")
public abstract class QueueSession<R extends Request<?>> { public abstract class QueueSession<R extends Request<?>> {
@Id @Id
@GeneratedValue(strategy = GenerationType.IDENTITY) @GeneratedValue(strategy = GenerationType.IDENTITY)
private Long id; private Long id;
......
...@@ -361,7 +361,6 @@ public class LabService { ...@@ -361,7 +361,6 @@ public class LabService {
*/ */
@Transactional @Transactional
public void deleteSession(QueueSession<?> session) { public void deleteSession(QueueSession<?> session) {
session.setDeletedAt(now());
qsr.delete(session); qsr.delete(session);
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment