fix endpoint & tests

src/main/java/nl/tudelft/queue/controller/HomeController.java

@@ -26,6 +26,7 @@ import java.util.*;
 import java.util.stream.Collectors;
 
 import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.http.ResponseEntity;
 import org.springframework.stereotype.Controller;
 import org.springframework.ui.Model;
 import org.springframework.web.bind.annotation.*;
@@ -273,10 +274,13 @@ public class HomeController {
 	 */
 	@GetMapping("/api/average-star-rating")
 	@ResponseBody
-	public Map<Long, Double> averageStarRating(@RequestParam("ids") List<Long> ids) {
-		return ids.stream().filter(id -> ps.canViewFeedback(id))
-				.collect(Collectors.toMap(id -> id,
+	public ResponseEntity<Map<Long, Double>> averageStarRating(@RequestParam("ids") List<Long> ids) {
+		Map<Long, Double> result = ids.stream()
+				.filter(id -> ps.canViewFeedback(id))
+				.collect(Collectors.toMap(
+						id -> id,
 						id -> fs.getAvgStarRating(fs.countRatings(fr.findByAssistant(id)))));
+		return ResponseEntity.ok(result);
 	}
 
 	/**

src/main/java/nl/tudelft/queue/security/DevSecurityConfig.java

@@ -22,11 +22,11 @@ import org.springframework.context.annotation.Profile;
 import org.springframework.security.config.annotation.web.builders.HttpSecurity;
 import org.springframework.security.config.annotation.web.configurers.HeadersConfigurer;
 
-import nl.tudelft.labracore.lib.security.LabradorSecurityConfig;
+import nl.tudelft.labracore.app.security.LabradorSecurityConfigWithApi;
 
 @Configuration
 @Profile("!production")
-public class DevSecurityConfig extends LabradorSecurityConfig {
+public class DevSecurityConfig extends LabradorSecurityConfigWithApi {
 
 	@Override
 	protected void configure(HttpSecurity http) throws Exception {

src/main/java/nl/tudelft/queue/security/ProductionSecurityConfig.java

@@ -21,11 +21,11 @@ import org.springframework.context.annotation.Configuration;
 import org.springframework.context.annotation.Profile;
 import org.springframework.security.config.annotation.web.builders.HttpSecurity;
 
-import nl.tudelft.labracore.lib.security.LabradorSecurityConfig;
+import nl.tudelft.labracore.app.security.LabradorSecurityConfigWithApi;
 
 @Configuration
 @Profile("production")
-public class ProductionSecurityConfig extends LabradorSecurityConfig {
+public class ProductionSecurityConfig extends LabradorSecurityConfigWithApi {
 	@Override
 	protected void configure(HttpSecurity http) throws Exception {
 		super.configure(http);

src/main/java/nl/tudelft/queue/service/FeedbackService.java

@@ -157,7 +157,7 @@ public class FeedbackService {
 			totalRatings += ratings.get(i) * (i + 1);
 			totalCount += ratings.get(i);
 		}
-		return totalCount == 0 ? null
+		return totalCount == 0 ? 0
 				: BigDecimal.valueOf((double) totalRatings / totalCount)
 						.setScale(1, RoundingMode.HALF_UP)
 						.doubleValue();

src/main/resources/templates/home/feedback.html

@@ -79,7 +79,6 @@
                                     Ratings range from 1 (needs improvement) to 5 (excellent) for request handling performance.
                                 </p>
                             </div>
-                            <h2 class="font-500" th:text="|Average Star Rating is ${starRating}|"></h2>
                         </div>
                         <div class="surface__content">
                             <canvas id="feedback-histogram"></canvas>

src/test/java/nl/tudelft/queue/controller/HomeControllerTest.java

@@ -212,12 +212,12 @@ public class HomeControllerTest {
 		when(feedbackService.countRatings(anyList())).thenReturn(List.of(2, 1, 1));
 		when(feedbackService.getAvgStarRating(anyList())).thenReturn(4.5);
 
-		MvcResult result = mvc.perform(get("/average-star-rating")
+		MvcResult result = mvc.perform(get("/api/average-star-rating")
 						.param("ids", "1", "2", "3")
 						.contentType(MediaType.APPLICATION_JSON))
 						.andExpect(status().isOk())
 						.andReturn();
-		assertEquals(result.getResponse().getContentAsString(),"{\"1\":4.5,\"2\":4.5,\"3\":4.5}");
+		assertEquals("{\"1\":4.5,\"2\":4.5,\"3\":4.5}", result.getResponse().getContentAsString());
 	}
 
 	@Test

src/test/java/nl/tudelft/queue/service/FeedbackServiceTest.java

@@ -20,7 +20,6 @@ package nl.tudelft.queue.service;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
 import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNull;
 
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -250,13 +249,13 @@ public class FeedbackServiceTest {
 
 	@Test
 	void getAvgStarRating() {
-		assertEquals(3.06, fs.getAvgStarRating(List.of(3, 2, 5, 1, 4)), 0.01);
+		assertEquals(3.1, fs.getAvgStarRating(List.of(3, 2, 5, 1, 4)), 0.01);
 	}
 
 	@Test
 	void getAvgStarRatingEmptyOrZerosList() {
-		assertNull(fs.getAvgStarRating(List.of()));
-		assertNull(fs.getAvgStarRating(List.of(0, 0, 0, 0, 0)));
+		assertEquals(0, fs.getAvgStarRating(List.of()));
+		assertEquals(0, fs.getAvgStarRating(List.of(0, 0, 0, 0, 0)));
 	}
 
 	@Test