Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Queue
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
EIP
Labrador
Queue
Commits
91f794d4
Commit
91f794d4
authored
Sep 27, 2023
by
Ruben Backx
Browse files
Options
Downloads
Patches
Plain Diff
Fix room select on lab copy
parent
69ea4219
Branches
main
No related tags found
2 merge requests
!720
Version 2.2.2
,
!717
Resolve "Room select gets deselected when copying a lab"
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
CHANGELOG.md
+1
-0
1 addition, 0 deletions
CHANGELOG.md
src/main/resources/templates/lab/create/components/lab-general.html
+10
-1
10 additions, 1 deletion
...esources/templates/lab/create/components/lab-general.html
with
11 additions
and
1 deletion
CHANGELOG.md
+
1
−
0
View file @
91f794d4
...
@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
...
@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
### Fixed
-
The about page was not accessible.
[
@rwbackx
](
https://gitlab.ewi.tudelft.nl/rwbackx
)
-
The about page was not accessible.
[
@rwbackx
](
https://gitlab.ewi.tudelft.nl/rwbackx
)
-
When copying a session, the rooms would not get copied over properly.
[
@rwbackx
](
https://gitlab.ewi.tudelft.nl/rwbackx
)
## [2.2.1]
## [2.2.1]
...
...
This diff is collapsed.
Click to expand it.
src/main/resources/templates/lab/create/components/lab-general.html
+
10
−
1
View file @
91f794d4
...
@@ -113,7 +113,13 @@
...
@@ -113,7 +113,13 @@
<label
for=
"room-select"
>
Rooms
</label>
<label
for=
"room-select"
>
Rooms
</label>
<div>
<div>
<select
multiple
id=
"room-select"
th:field=
"*{rooms}"
data-select
disabled
data-placeholder=
"Pick a room"
>
<select
multiple
id=
"room-select"
th:field=
"*{rooms}"
data-select
th:disabled=
"${#lists.isEmpty(dto.roomDetails())}"
data-placeholder=
"Pick a room"
>
<th:block
th:each=
"room : ${rooms}"
>
<th:block
th:each=
"room : ${rooms}"
>
<option
<option
th:value=
"${room.id}"
th:value=
"${room.id}"
...
@@ -124,6 +130,9 @@
...
@@ -124,6 +130,9 @@
</th:block>
</th:block>
</select>
</select>
</div>
</div>
<script
th:unless=
"${#lists.isEmpty(dto.roomDetails())}"
>
document
.
addEventListener
(
"
ComponentsLoaded
"
,
updateRooms
);
</script>
<label
for=
"online-mode-select"
>
Online Modes
</label>
<label
for=
"online-mode-select"
>
Online Modes
</label>
<div>
<div>
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
sign in
to comment