Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Queue
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
EIP
Labrador
Queue
Commits
b2ce24a3
Commit
b2ce24a3
authored
2 months ago
by
Henry Page
Browse files
Options
Downloads
Patches
Plain Diff
[ConsecutiveQueueSlots] Fixed being able to take untakeable slots
parent
ee664468
Branches
Branches containing commit
Tags
v0.6.1
Tags containing commit
2 merge requests
!841
2425.0.0 release
,
!840
Resolve "Consecutive slotted labs: UI does not restrict enqueuing on later slots."
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
CHANGELOG.md
+1
-1
1 addition, 1 deletion
CHANGELOG.md
src/main/resources/static/js/time_slots.js
+1
-1
1 addition, 1 deletion
src/main/resources/static/js/time_slots.js
src/main/resources/templates/lab/enqueue/lab.html
+2
-2
2 additions, 2 deletions
src/main/resources/templates/lab/enqueue/lab.html
with
4 additions
and
4 deletions
CHANGELOG.md
+
1
−
1
View file @
b2ce24a3
...
...
@@ -15,10 +15,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
-
If a room has a map, students can now click the map to indicate their location. @rwbackx
### Changed
-
Waiting time and processing time now uses consistent calculations.
[
@hpage
](
https://gitlab.ewi.tudelft.nl/hpage
)
### Fixed
-
Fix the copying of labs
[
@mmadara
](
https://gitlab.ewi.tudelft.nl/mmadara
)
-
Slot selection now throws an error if user selects non-consecutive slot in consecutive labs.
[
@hpage
](
https://gitlab.ewi.tudelft.nl/hpage
)
## [2.4.0]
...
...
This diff is collapsed.
Click to expand it.
src/main/resources/static/js/time_slots.js
+
1
−
1
View file @
b2ce24a3
...
...
@@ -287,7 +287,7 @@ class TimeSlot {
* @param requests The requests in the timeslot
* @param options Optional configuration.
*/
constructor
(
id
,
start
,
end
,
occupancy
,
capacity
,
requests
,
options
)
{
constructor
(
id
,
start
,
end
,
occupancy
,
capacity
,
requests
,
options
=
{}
)
{
this
.
id
=
id
===
undefined
?
(
TimeSlot
.
nextId
++
).
toString
()
:
id
;
this
.
start
=
start
;
this
.
end
=
end
;
...
...
This diff is collapsed.
Click to expand it.
src/main/resources/templates/lab/enqueue/lab.html
+
2
−
2
View file @
b2ce24a3
...
...
@@ -54,7 +54,7 @@
<span>
Select a time slot
</span>
<div
id=
"slot-select"
style=
"max-height: 30rem"
></div>
</div>
<p
class=
"fw-500 colour-error"
hidden
id=
"time-slot-warning"
>
Please select a time slot
</p>
<p
class=
"fw-500 colour-error"
hidden
id=
"time-slot-warning"
>
Please select a
valid
time slot
</p>
<div>
<span>
Selected time slot:
</span>
<span
id=
"selected-slot"
class=
"fw-500"
>
none
</span>
...
...
@@ -120,7 +120,7 @@
// Show error if trying to enqueue without slot
document
.
getElementById
(
"
enqueue-form
"
).
addEventListener
(
"
submit
"
,
function
(
event
)
{
if
(
timeSlots
.
selected
===
undefined
)
{
if
(
timeSlots
.
selected
===
undefined
||
timeSlots
.
selected
.
untakable
)
{
document
.
getElementById
(
"
time-slot-warning
"
).
removeAttribute
(
"
hidden
"
);
event
.
preventDefault
();
event
.
stopPropagation
();
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
sign in
to comment