Refactor to have only one pagination.html template

Three different instances of pagination could be found throughout the project. This only needs to be a single instance as all pagination elements do exactly the same thing: provide buttons to change the query parameter of page and fetch the current page with the changed query parameters.

The location of /templates/pagination.html was chosen because it is the most generic place for such a generic template. Most, if not all, of the implementation of pagination was copied from /templates/request/list/pagination.html because the existing implementation there was most complete and most recently worked on. The 'new' pagination.html template/fragment was given explicit parameters for a Page object to figure out the current page and total page count etc. Additionally, the size (width) of the pagination element is passed explicitle. The value used by default before was 3.

The CourseController based function to fetch a list of students was adjusted to output a Page object into the model, as required for the pagination to work similarly to that of all other paginated pages.

Closes #233 (closed)

added typefeature-request label

added 3 commits

• 4466a26f...6c44de15 - 2 commits from branch development
• cc9bf1f7 - Refactor to have only one pagination.html template

Compare with previous version

assigned to @LiamClark

added 794 commits

• cc9bf1f7...f9023090 - 793 commits from branch development
• 49b3b33e - Refactor to have only one pagination.html template

Compare with previous version

@Lemaire Don't forget to fix the merge conflicts

added 99 commits

• 49b3b33e...d2fd9684 - 98 commits from branch development
• 8f752659 - Refactor to have only one pagination.html template

Compare with previous version

resolved all threads

@Lemaire Seems great! a few questions but honestly I don't care too much about the thymeleaf templates. Great that you made it consistent and even better that you wrote a meaningful commit message <3!

There's a few deprecations for pagination in the move to spring 5. Would it be ok to delay merging this until that's merged? that we can fix those here?

added 5 commits

• 8f752659...aaf5c23b - 4 commits from branch development
• 63508bfc - Refactor to have only one pagination.html template

Compare with previous version

changed the description

added 109 commits

• 63508bfc...727ae2f8 - 108 commits from branch development
• 62b0bd8c - Refactor to have only one pagination.html template

Compare with previous version

added 1 commit

• fd6a6790 - Add padding to course view pages

Compare with previous version

resolved all threads

added 56 commits

• fd6a6790...36a07b01 - 54 commits from branch development
• d9aa1110 - Refactor to have only one pagination.html template
• b70fbf2c - Add padding to course view pages

Compare with previous version

added 29 commits

• b70fbf2c...52f7917a - 27 commits from branch development
• 0e5bf139 - Refactor to have only one pagination.html template
• 32a1f0b3 - Add padding to course view pages

Compare with previous version

added 16 commits

• 32a1f0b3...6acb5c57 - 14 commits from branch development
• 16ec0a88 - Refactor to have only one pagination.html template
• dd61089c - Add padding to course view pages

Compare with previous version

approved this merge request

started a merge train

mentioned in commit e7211160

merged

unassigned @LiamClark