Skip to content
Snippets Groups Projects

Fix filtering of push notifications

Merged Fix filtering of push notifications
90-push-notifications-ignore-filter-settings into development
Merged
Chris Lemairerequested to merge
90-push-notifications-ignore-filter-settings into development
  1. Dec 16, 2019
  3. Dec 11, 2019
    • Chris Lemaire's avatar
      Fix filtering of push notifications · d126bfda
      Chris Lemaire authored 
      
- Adjust request serialization to a hashmap to reflect the use of display names.
- Rename 'requesttable' key in request table updates to 'request'.
  This name better suits the data, which is just a request object serialized in a
  very specific way.
- Fix filtering of push notifications for request table updates to use the selected
  filters as they are selected at the moment the page is fully loaded.
  This includes a change to the way the selected texts are fetched: if no selected
  options could be found, all options are selected by default.
- Clear up the usage of some magically serialized push messages in request_table.js.
  By passing the key as a string literal instead of using field notation, it is clearer
  that this relation is complete magic.
- Change the assigned filter to display the full name of the currently logged in user
  instead of 'You' and sort the list of assistants by display name.
- Add comments to clear up some implicit dependencies between objects in the HTML.

Signed-off-by: default avatarChris Lemaire <c.lemaire@student.tudelft.nl>
      d126bfda