Skip to content
Snippets Groups Projects

Fix "clear filter" button appearing

What does this mr do?

The "clear filter" button had been appearing even when the submission didn't include any actual filters.

Actions taken to fix bug

Added a condition which checks whether the query params contain any filtering parameters before actually submitting them.

Does this MR meet the acceptance criteria?

  • I have added a changelog entry to reflect the significant changes I made and the bug I fixed.
  • A test was created to test the bug.
  • I have updated the documentation accordingly.
  • I adhere to the style guide.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 56dac0d3 - Apply suggestion to src/main/java/nl/tudelft/ewi/queue/service/RequestTableService.java

    Compare with previous version

  • added 1 commit

    • b526e825 - Fix "clear filter" button appearing

    Compare with previous version

  • Sára Juhošová resolved all threads

    resolved all threads

  • Liam Clark approved this merge request

    approved this merge request

  • Chris Lemaire approved this merge request

    approved this merge request

  • Chris Lemaire unapproved this merge request

    unapproved this merge request

  • added 1 commit

    • 326592e4 - Fix "clear filter" button appearing

    Compare with previous version

  • Sára Juhošová resolved all threads

    resolved all threads

  • Otto Visser approved this merge request

    approved this merge request

  • Otto Visser started a merge train

    started a merge train

  • merged

  • Otto Visser mentioned in commit f80ee109

    mentioned in commit f80ee109

  • Please register or sign in to reply
    Loading