Skip to content
Snippets Groups Projects

Replace net id with user id in unenque request.

What does this mr do?

Managers and higher level users were unable to unenqueue students from the queue because in the template the user was giving the netid as a paramter and the controller was expecting the username.

Actions taken to fix bug

The parameter has been changed to the user's id in both places to make it easier to keep everything consistent.

Does this MR meet the acceptance criteria?

  • I have added a changelog entry to reflect the significant changes I made and the bug I fixed.
  • A test was created to test the bug.
  • I have updated the documentation accordingly.
  • I adhere to the style guide.

closes #273 (closed)

Edited by Cédric Willekens

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Liam Clark
  • Liam Clark
  • Liam Clark
  • Liam Clark
  • Liam Clark
  • Liam Clark
  • Seems like a good fix! I just have a few questions that are more related to how we're doing development than to this issue. @otto if you want to deploy this today feel free to do so.

  • added 1 commit

    • 2e524a00 - Replace net id with user id in unenque request.

    Compare with previous version

  • Cédric Willekens marked the checklist item I have added a changelog entry to reflect the significant changes I made and the bug I fixed. as completed

    marked the checklist item I have added a changelog entry to reflect the significant changes I made and the bug I fixed. as completed

  • Cédric Willekens changed the description

    changed the description

  • added 1 commit

    • d57d03c7 - Replace net id with user id in unenque request.

    Compare with previous version

  • added 1 commit

    • 05e04174 - Replace net id with user id in unenque request.

    Compare with previous version

  • Otto Visser resolved all threads

    resolved all threads

  • Otto Visser approved this merge request

    approved this merge request

  • Otto Visser started a merge train

    started a merge train

  • merged

  • Otto Visser mentioned in commit 8948b7a5

    mentioned in commit 8948b7a5

  • Please register or sign in to reply
    Loading