Add the possibility for students to change the location and question of their request (#222)
This merge request contains a feature that students can update their room, the comment (their location in the room) and the question.
Update block
There already exists a possibility to update the room, next to this I added two textfields where student can see their current comment / question and update them if they choose to. Also the title of the block is changed. I decided to get rid of the word room, since logically it is a subset of location and with all three words the title seemed too long.
Update message changed
Since now, the student is allowed to change more than just their room location, the update message should also change to reflect this.
Other code changes
- Most of other code changes is renaming of methods and parameters. As already explained all names such as
updateRoom
andupdateRoomInfo
are changed toupdateRequestInfo
to correctly name the method. - To pass around the values of comment and question new parameters were added to controller on server.
- Showing and hiding of the two textfields is adjusted so that they are visible.
Closes #222 (closed)
Merge request reports
Activity
added 11 commits
-
027f830e...edbeb64b - 10 commits from branch
eip/labrador:development
- e6916d45 - Merge branch 'development' into...
-
027f830e...edbeb64b - 10 commits from branch
- Resolved by Chris Lemaire
All in all this looks very good!
Thanks for contributing, sorry it took a time to get to reviewing your request. Aside from the one comment, there's not much to note :)
Edited by Chris Lemaire- Resolved by Chris Lemaire
added 106 commits
-
e6916d45...6acb5c57 - 104 commits from branch
eip/labrador:development
- cad31112 - Merge branch 'development' of https://gitlab.ewi.tudelft.nl/eip/labrador/queue...
- bfc49498 - Resolve feedback from Chris on the merge request
-
e6916d45...6acb5c57 - 104 commits from branch
- Resolved by Chris Lemaire
mentioned in commit 7c737a91