Skip to content
Snippets Groups Projects

Add the possibility for students to change the location and question of their request (#222)

This merge request contains a feature that students can update their room, the comment (their location in the room) and the question.

Update block

There already exists a possibility to update the room, next to this I added two textfields where student can see their current comment / question and update them if they choose to. Also the title of the block is changed. I decided to get rid of the word room, since logically it is a subset of location and with all three words the title seemed too long.

before: empty-before now: empty-after

Update message changed

Since now, the student is allowed to change more than just their room location, the update message should also change to reflect this.

before: updatetext-before

now: updatetext-after

Other code changes

  • Most of other code changes is renaming of methods and parameters. As already explained all names such as updateRoom and updateRoomInfo are changed to updateRequestInfo to correctly name the method.
  • To pass around the values of comment and question new parameters were added to controller on server.
  • Showing and hiding of the two textfields is adjusted so that they are visible.

Closes #222 (closed)

Edited by Marko Matušovič

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • All in all this looks very good!

    Thanks for contributing, sorry it took a time to get to reviewing your request. Aside from the one comment, there's not much to note :)

    Edited by Chris Lemaire
  • Marko Matušovič added 106 commits

    added 106 commits

    Compare with previous version

  • Chris Lemaire
  • added 1 commit

    • d30190c7 - Add minlength restriction to comment input

    Compare with previous version

  • added 1 commit

    • 60fff97f - Correct the minlength placement

    Compare with previous version

  • Chris Lemaire resolved all threads

    resolved all threads

  • Chris Lemaire approved this merge request

    approved this merge request

  • Otto Visser approved this merge request

    approved this merge request

  • Otto Visser mentioned in commit 7c737a91

    mentioned in commit 7c737a91

  • merged

  • Please register or sign in to reply
    Loading