Skip to content
Snippets Groups Projects

Replace SockJS dependency with plain Websockets

All threads resolved!

What does this mr do?

SockJS is a dependency we used to setup a websocket connection. However, with the upgrade to Spring 2, this dependency started misbehaving and Stomp gave us errors for that. It had something to do with CORS and giving the client the right CDN url for downloading SockJS. One option to fix the bug seemed to be to set CORS to allow all cross-site requests and set a static CDN url for downloading SockJS.

Actions taken to fix bug

The fix to this has been to remove SockJS and replace it with native Websocket support from the browser. The changes to make this happen are small and only change stomp related code to use native support and tell spring not to use SockJS.

Does this MR meet the acceptance criteria?

  • I have added a changelog entry to reflect the significant changes I made and the bug I fixed.
  • A test was created to test the bug.
  • I have updated the documentation accordingly.
  • I adhere to the style guide.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Chris Lemaire added 1 commit

    added 1 commit

    • 36456a5d - Replace SockJS dependency with plain Websockets

    Compare with previous version

  • Otto Visser resolved all threads

    resolved all threads

  • Otto Visser approved this merge request

    approved this merge request

  • Otto Visser enabled automatic add to merge train when the pipeline for 23177615 succeeds

    enabled automatic add to merge train when the pipeline for 23177615 succeeds

  • Otto Visser started a merge train

    started a merge train

  • merged

  • Otto Visser mentioned in commit cb6352ad

    mentioned in commit cb6352ad

  • Please register or sign in to reply
    Loading