Skip to content
Snippets Groups Projects

Move security files and remove roles

All threads resolved!

This MR attacks the scatteredness and complicatedness of our Security configurations.

I would like to propose we move all security related classes into a package 'security' for the sake of having this bubble of connected classes in the same place. This helps in understanding which classes do what in the security hierarchy, rather than having AuthenticationService (which is a UserDetailsService) in the services directory.

Edited by Chris Lemaire

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Just one remark. Other than that good refactor.

  • Chris Lemaire resolved all threads

    resolved all threads

  • Chris Lemaire added 1 commit

    added 1 commit

    • b26dd0a3 - Apply suggestion to src/main/java/nl/tudelft/ewi/queue/security/dev/AuthenticationService.java

    Compare with previous version

  • Chris Lemaire added 56 commits

    added 56 commits

    • b26dd0a3...5dc9cb1a - 54 commits from branch development
    • acb2fcd1 - Move security files and remove roles
    • 8d47ffba - Apply suggestion to src/main/java/nl/tudelft/ewi/queue/security/dev/AuthenticationService.java

    Compare with previous version

  • Chris Lemaire added 1 commit

    added 1 commit

    • 310274f4 - Apply suggestion to src/main/java/nl/tudelft/ewi/queue/security/dev/AuthenticationService.java

    Compare with previous version

  • Chris Lemaire resolved all threads

    resolved all threads

  • Cédric Willekens approved this merge request

    approved this merge request

  • Chris Lemaire added 274 commits

    added 274 commits

    • 310274f4...69e5f575 - 272 commits from branch development
    • 0c3be689 - Move security files and remove roles
    • d38da8e2 - Apply suggestion to src/main/java/nl/tudelft/ewi/queue/security/dev/AuthenticationService.java

    Compare with previous version

  • Chris Lemaire added 1 commit

    added 1 commit

    • 6f274abc - Apply suggestion to src/main/java/nl/tudelft/ewi/queue/security/dev/AuthenticationService.java

    Compare with previous version

  • Chris Lemaire added 1 commit

    added 1 commit

    • 1deab638 - Apply suggestion to src/main/java/nl/tudelft/ewi/queue/security/dev/AuthenticationService.java

    Compare with previous version

  • Otto Visser resolved all threads

    resolved all threads

  • Otto Visser approved this merge request

    approved this merge request

  • Otto Visser added this merge request to the merge train at position 3

    added this merge request to the merge train at position 3

  • merged

  • Otto Visser mentioned in commit a8110b99

    mentioned in commit a8110b99

  • Otto Visser mentioned in commit 7290a683

    mentioned in commit 7290a683

  • Please register or sign in to reply
    Loading