Resolve "Room map images are fetched; regardless of whether they exist and whether the page even can display a map"
Merged
308-room-map-images-are-fetched-regardless-of-whether-they-exist-and-whether-the-page-even-can into development
All threads resolved!
What does this mr do?
A client was looking for a room which could not be found. I was unable to find the cause of this and/or reproduce this bug. However this will solve the problem of errors being thrown constantly.
Actions taken to fix bug
Do not throw an exception when the room map cannot be found but just return an empty room.
Does this MR meet the acceptance criteria?
-
I have added a changelog entry to reflect the significant changes I made and the bug I fixed. -
A test was created to test the bug. -
I have updated the documentation accordingly. -
I adhere to the style guide. closes #308 (closed)
Edited by Cédric Willekens
Merge request reports
Activity
added priomed statusconfirmed typebug labels
added 1 commit
- d9a41b02 - Return empty room if cannot be found instead of throwing error
- Resolved by Chris Lemaire
Can we combine this effort with !290 (closed) and instead of new room() return the default room image?
added 263 commits
-
d9a41b02...9a94d2a1 - 262 commits from branch
development - 84c9662e - Return empty room if cannot be found instead of throwing error
-
d9a41b02...9a94d2a1 - 262 commits from branch
mentioned in commit 725c83cb
Please register or sign in to reply