Resolve "weblab link is incorrect"

What does this mr do?

Fixes the WebLab link of a submission. Automatically @tudelft.nl was added to the end of the link but this is removed now.

Actions taken to fix bug

Add a method in UserService to remove the currently selected emailSuffix in application.yaml. Then remove the email suffix whenever the link itself is created in the RequestController.

Does this MR meet the acceptance criteria?

• I have added a changelog entry to reflect the significant changes I made and the bug I fixed.
• A test was created to test the bug.
• I have updated the documentation accordingly.
• I adhere to the style guide.

Closes #187 (closed)

added priomed typebug labels

added 1 commit

• 54dd1f20 - Update CHANGELOG.md

Compare with previous version

marked the checklist item I have added a changelog entry to reflect the significant changes I made and the bug I fixed. as completed

mentioned in merge request !309 (merged)

added 1 commit

• 901899be - Change all guaranteeValidNetId to access UserService

Compare with previous version

resolved all threads

Also, the commit history here seems like it has some extra things not related to this MR. Are you based on a branch that hasn't yet been merged?

This merge request is based on top of !309 (merged), it had to do with the emailsuffix and getting that from the config file. Since that is merged a rebase should fix all the commits since they are the same.

mentioned in issue #334 (closed)

added 195 commits

• 901899be...b0625d18 - 191 commits from branch development
• f6d88445 - Update CHANGELOG.md
• cd1658ff - Remove emailSuffix in weblab link
• 5a8e16cc - Add functionality to remove email suffix of netid
• 5a85d476 - Change all guaranteeValidNetId to access UserService

Compare with previous version

added 1 commit

• 063404af - Change all guaranteeValidNetId to access UserService

Compare with previous version

Can you rebase again? After merging Otto's hotfixes, we now have the changes you proposed in your latest commit in development I believe.

added 11 commits

• 063404af...e540d91c - 7 commits from branch development
• 856b9295 - Update CHANGELOG.md
• 3379bafa - Remove emailSuffix in weblab link
• 4b506db0 - Add functionality to remove email suffix of netid
• b42ded02 - Change all guaranteeValidNetId to access UserService

Compare with previous version

added 1 commit

• bdcf687e - Change all guaranteeValidNetId to access UserService

Compare with previous version

approved this merge request

unapproved this merge request

added 1 commit

• bd394358 - Change all guaranteeValidNetId to access UserService

Compare with previous version

approved this merge request

resolved all threads

approved this merge request

started a merge train

mentioned in commit 0dc417dc

merged

unassigned @tnulle