Skip to content
Snippets Groups Projects

Resolve "Support for the notion of groups"

What does this mr do?

Adds a warning message that labs will break if no groups are imported. When no groups are imported and trying to create a lab it will give a warning that groups need to be imported. It will also restrict access to the lab creation page if a course has groups and there are no mentor groups available. This such that there is no way a course can create a lab without any students in it.

Also solves a small issue where a teacher accidentally checks the "uses groups" checkbox and now it can be disabled once.

Screenshots

after

Screenshot_2020-05-05_at_09.46.18

Does this MR meet the acceptance criteria?

  • I have added a changelog entry to reflect the significant changes I made.
  • Tests were created to test the feature.
  • I have updated the documentation accordingly.
  • I adhere to the style guide.

Closes #100 (closed) Closes #117 (closed)

Edited by Thijs Nulle

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Otto Visser
  • Thijs Nulle added 1 commit

    added 1 commit

    • 2a054d9e - Use course groups instead of first year mentor groups

    Compare with previous version

  • Thijs Nulle added 1 commit

    added 1 commit

    • d6987179 - Use course groups instead of first year mentor groups

    Compare with previous version

  • Thijs Nulle changed the description

    changed the description

  • Thijs Nulle added 1 commit

    added 1 commit

    • daa1daf5 - Use course groups instead of first year mentor groups

    Compare with previous version

  • Otto Visser resolved all threads

    resolved all threads

  • Otto Visser added 64 commits

    added 64 commits

    • daa1daf5...1a2cf826 - 63 commits from branch development
    • 7bca3356 - Merge branch 'development' into '117-support-for-the-notion-of-groups'

    Compare with previous version

  • Otto Visser added 1 commit

    added 1 commit

    • 4d0675f1 - Fix the merge conflict resolution of GitLab

    Compare with previous version

  • Chris Lemaire approved this merge request

    approved this merge request

  • Chris Lemaire started a merge train

    started a merge train

  • Chris Lemaire mentioned in commit 644bc777

    mentioned in commit 644bc777

  • unassigned @tnulle

  • Please register or sign in to reply
    Loading