Skip to content
Snippets Groups Projects

Resolve "[Queue-2.0] Removing Labs"

All threads resolved!

What does this mr do?

Make sure the user gets directed to the correct pages when clicking the delete buttons for a lab.

Actions taken to fix bug

Does this MR meet the acceptance criteria?

  • I have added a changelog entry to reflect the significant changes I made and the bug I fixed.
  • A test was created to test the bug.
  • I have updated the documentation accordingly.
  • I adhere to the style guide. Closes #376 (closed)
Edited by Cédric Willekens

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 7b12b81a - Prevent deleted labs from being shown

    Compare with previous version

  • added 8 commits

    • 7b12b81a...891a4ec3 - 3 commits from branch queue-v2.0
    • 3a11c654 - References for lab removal should point to correct url's
    • c11c880a - Update changelog
    • a0ef4804 - Prevent deleted labs from showing in the overview
    • c285ddc7 - Add tests for new functionality
    • 51586c53 - Prevent deleted labs from being shown

    Compare with previous version

  • added 1 commit

    • 4bb333d7 - Fix test after changing lab model

    Compare with previous version

  • added 1 commit

    • d2b6a4a8 - Fix test after changing lab model

    Compare with previous version

  • added 1 commit

    • 6c9a238a - Fix test after changing lab model

    Compare with previous version

  • added 1 commit

    • 787c9fe0 - Fix test after changing lab model

    Compare with previous version

  • added 1 commit

    • 7f113202 - Fix test after changing lab model

    Compare with previous version

  • added 1 commit

    • 54ff6ad0 - Resolve errors caused by labcontrollertests

    Compare with previous version

  • Cédric Willekens marked the checklist item A test was created to test the bug. as completed

    marked the checklist item A test was created to test the bug. as completed

  • Chris Lemaire resolved all threads

    resolved all threads

  • added 1 commit

    • 7764a956 - Resolve errors caused by labcontrollertests

    Compare with previous version

  • added 1 commit

    • 3ca3a93a - Revert changes made to properties files

    Compare with previous version

  • added 1 commit

    • 490dd3bd - Make requestcontroller tests class transactional

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Chris Lemaire resolved all threads

    resolved all threads

  • Alrighty looks like this has been ready to merge since your latest changes. Thank you very much for fixing the test!

  • Chris Lemaire started a merge train

    started a merge train

  • Chris Lemaire approved this merge request

    approved this merge request

  • Chris Lemaire mentioned in commit 03c9b339

    mentioned in commit 03c9b339

  • mentioned in issue #376 (closed)

  • Please register or sign in to reply
    Loading