Resolve "[Queue-2.0] Removing Labs"
All threads resolved!
All threads resolved!
What does this mr do?
Make sure the user gets directed to the correct pages when clicking the delete buttons for a lab.
Actions taken to fix bug
Does this MR meet the acceptance criteria?
-
I have added a changelog entry to reflect the significant changes I made and the bug I fixed. -
A test was created to test the bug. -
I have updated the documentation accordingly. -
I adhere to the style guide. Closes #376 (closed)
Edited by Cédric Willekens
Merge request reports
Activity
added typefeature-request + 1 deleted label
added 2 commits
- Resolved by Chris Lemaire
@Lemaire The post method for delete a lab still has a TODO in it. It refers to redirecting to an edition collection specific page for shared labs. Correct me if I'm wrong, there is no page for this yet? Is there already an issue for such a page?
- Resolved by Chris Lemaire
added 8 commits
-
7b12b81a...891a4ec3 - 3 commits from branch
queue-v2.0 - 3a11c654 - References for lab removal should point to correct url's
- c11c880a - Update changelog
- a0ef4804 - Prevent deleted labs from showing in the overview
- c285ddc7 - Add tests for new functionality
- 51586c53 - Prevent deleted labs from being shown
Toggle commit list-
7b12b81a...891a4ec3 - 3 commits from branch
- Resolved by Cédric Willekens
The error could be a problem with the
labobject getting unbound. To fix this, you might have to callflushon the repository, or you might (also) have to refetch thelabobject (just usefindById).
- Resolved by Chris Lemaire
- Resolved by Chris Lemaire
added 1 commit
- 490dd3bd - Make requestcontroller tests class transactional
mentioned in commit 03c9b339
mentioned in issue #376 (closed)
unassigned @cedricwilleken
Please register or sign in to reply