Resolve "[Queue-2.0] Slotted lab not loading for Student"
What does this mr do?
Make sure that thymeleaf has access to the data
object from the SlottedLabViewDTO
.
Actions taken to fix bug
Add method getData
to SlottedLabViewDTO
to make sure this object is available to thymleaf and add test to make sure this erroring thymeleaf page is being displayed correctly.
Does this MR meet the acceptance criteria?
-
I have added a changelog entry to reflect the significant changes I made and the bug I fixed. -
A test was created to test the bug. -
I have updated the documentation accordingly. -
I adhere to the style guide.
Closes #386 (closed)
Merge request reports
Activity
changed milestone to %Queue 2.0 Initial deploy
added 1 commit
- 49a70b8a - Make sure data object from SlottedLabViewDTO is accessible to thymeleaf
added 1 commit
- f3118527 - Make labService a spy for LabController test
- Resolved by Cédric Willekens
Oh whoops, I didn't see you opened this yesterday. It seems I have solved the issue similarly in my MR !434 (merged). It also seems I made a duplicate issue whoops... Let me wait for my pipeline to be resolved, if it does not pass, it's best to use your work.
I would propose one change, that is, could you copy paste the
getData
function intoLabViewDTO
? As this seems to be a problem for multiple lab types.
added 7 commits
-
f3118527...ee580696 - 4 commits from branch
queue-v2.0
- e0883f52 - Make sure data object from SlottedLabViewDTO is accessible to thymeleaf
- 61be06f9 - Add changelog entry
- eb47aee6 - Make labService a spy for LabController test
Toggle commit list-
f3118527...ee580696 - 4 commits from branch
mentioned in commit 7c6011d7
unassigned @cedricwilleken