Resolve "Changing the date of a slotted lab does not move the slots"
What does this mr do?
If a slotted lab is edited, it's slots won't update since they are represented by a Slot which has a fixed start and end. This needs to be switched to an offset based on the start of the lab. `
Actions taken to fix bug
Added a new offsetSequence number to denote the position of a slot within a slotted lab. The reason we did not get rid of the slot from the timeslot completely, was that it did not work with QueryDSL.
Screenshots
Before Change:
After Change:
Note that this MR does not support a change in the length of the lab whilst the offset changes. This will be addressed in another MR.
Does this MR meet the acceptance criteria?
-
I have added a changelog entry to reflect the significant changes I made and the bug I fixed. -
A test was created to test the bug. -
I have updated the documentation accordingly. -
I adhere to the style guide.
Merge request reports
Activity
added priomed statusdoing typeimprovement labels
assigned to @hpage
added 35 commits
-
75e428ec...13aacbd0 - 32 commits from branch
development - e8bea3e2 - update javadoc
- 47c13439 - Merge branch 'development' of gitlab.ewi.tudelft.nl:eip/labrador/queue into...
- 860b386e - Added migration for additional column
Toggle commit list-
75e428ec...13aacbd0 - 32 commits from branch
- Resolved by Henry Page
I see you have opted for adding a sequence number to the time-slots. This does indeed resolve some tracking issues we had by not knowing the index of a time-slot, but it also opens the door for a few new issues:
By keeping track of both slot times and slot indexes, either could be forgotten during updates in new code. If a desync occurs, we'll probably open Queue up for a whole new set of Database issues
I was hoping to only use sequencing numbers and calculate the slot on-demand. Perhaps this could be as easy as making the
Slotclass calculate its length without storing and retrieving this information from the database. This way we need to make minimal changes while also removing the need for storing the slot times for every slot. - Last reply by Henry Page
added 1 commit
- 86596853 - new offset based implementation, QueryDSL broken
added 1 commit
- 894fd451 - Revert "new offset based implementation, QueryDSL broken"
added 11 commits
-
59ec0350...2f39089b - 10 commits from branch
development - 8b7d2129 - Resolve MR conflict
-
59ec0350...2f39089b - 10 commits from branch
added 69 commits
-
8b7d2129...5383c661 - 67 commits from branch
development - fb4774c8 - switch migration order
- 2cd23316 - Merge branch 'development' of gitlab.ewi.tudelft.nl:eip/labrador/queue into...
-
8b7d2129...5383c661 - 67 commits from branch
added 20 commits
-
3340f886...50f02f55 - 16 commits from branch
development - 30ac1fbd - change location of changelog entry
- b4a5ca6a - fix overlapping time during update
- 1cc7b553 - Merge branch 'development' of gitlab.ewi.tudelft.nl:eip/labrador/queue into...
- 3bd8f72b - drop unique constraints
Toggle commit list-
3340f886...50f02f55 - 16 commits from branch
added 4 commits
-
e8a5e48c...45dce19c - 2 commits from branch
development - 1e1ed339 - Merge branch 'development' of gitlab.ewi.tudelft.nl:eip/labrador/queue into...
- 14828163 - last last last ditch attempt
-
e8a5e48c...45dce19c - 2 commits from branch
added 17 commits
-
65cd4cda...315f6a04 - 14 commits from branch
development - f6d19a9c - fix everything
- 15a845d5 - Merge branch 'development' of gitlab.ewi.tudelft.nl:eip/labrador/queue into...
- 27f6ac6b - fix changelog
Toggle commit list-
65cd4cda...315f6a04 - 14 commits from branch
requested review from @toberhuber, @cchen9, and @rgaghi
removed review request for @rgaghi, @toberhuber, and @cchen9
added 15 commits
-
2f65d4f4...61923976 - 14 commits from branch
development - 9caf1e29 - fix conflict
-
2f65d4f4...61923976 - 14 commits from branch
