Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Queue Queue
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 115
    • Issues 115
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 9
    • Merge requests 9
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • EIPEIP
  • LabradorLabrador
  • QueueQueue
  • Merge requests
  • !617

Draft: Resolve "Changing the date of a slotted lab does not move the slots"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Henry Page requested to merge 572-changing-the-date-of-a-slotted-lab-does-not-move-the-slots into development Oct 17, 2022
  • Overview 4
  • Commits 26
  • Pipelines 0
  • Changes 9

What does this mr do?

If a slotted lab is edited, it's slots won't update since they are represented by a Slot which has a fixed start and end. This needs to be switched to an offset based on the start of the lab. `

Actions taken to fix bug

Added a new offsetSequence number to denote the position of a slot within a slotted lab. The reason we did not get rid of the slot from the timeslot completely, was that it did not work with QueryDSL.

Screenshots

Before Change: image

After Change: image

Note that this MR does not support a change in the length of the lab whilst the offset changes. This will be addressed in another MR.

Does this MR meet the acceptance criteria?

  • I have added a changelog entry to reflect the significant changes I made and the bug I fixed.
  • A test was created to test the bug.
  • I have updated the documentation accordingly.
  • I adhere to the style guide.
Edited Nov 27, 2022 by Henry Page
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 572-changing-the-date-of-a-slotted-lab-does-not-move-the-slots