Skip to content
Snippets Groups Projects

Resolve "Deal with feedbacks that are associated with deleted requests"

What does this mr do?

Shows deleted feedback in the overview.

Screenshots

Manager View

image

TAM View

image

Admin View

image

Does this MR meet the acceptance criteria?

  • I have added a changelog entry to reflect the significant changes I made.
  • Tests were created to test the feature.
  • I have updated the documentation accordingly.
  • I adhere to the style guide.

Closes #616 (closed)

Edited by Henry Page

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ruben Backx
    • Resolved by Henry Page

      I think it would probably be better to add a onDeletedRequest field to FeedbackViewDTO and then set that to true, so we can display all feedbacks in the same order as before. Also, should the feedback actually be deleted? We should probably just delete the request and not the feedback, because in my mind:

      • Request deleted -> feedback still visible 'on deleted request' for TA
      • Feedback deleted -> feedback still visible to admin for accountability reasons but no longer to TA
  • Henry Page changed the description

    changed the description

  • Henry Page added 80 commits

    added 80 commits

    Compare with previous version

  • Henry Page added 1 commit

    added 1 commit

    • eedb157f - change table name in native query

    Compare with previous version

    • Author Developer
      Resolved by Ruben Backx

      @rwbackx Everything is implemented as discussed before. This leaves 1 more thing, namely the preexisting migrations which deal with feedbacks. Do I simply get rid of them or???

      - changeSet:
            id: 1668721308765-M1
            author: Henry Page
            changes:
              - sql:
                  comment: (MariaDB) Update feedbacks that have deleted requests to have same deletion time
                  dbms: mariadb
                  sql: UPDATE feedback AS f INNER JOIN request AS r ON r.id=f.request_id SET f.deleted_at = r.deleted_at WHERE r.deleted_at IS NOT NULL;
        - changeSet:
            id: 1668721308765-M2
            author: Henry Page
            changes:
              - sql:
                  comment: (PGSQL) Update feedbacks that have deleted requests to have same deletion time
                  dbms: postgresql
                  sql: UPDATE feedback AS f SET deleted_at = r.deleted_at FROM request AS r WHERE f.request_id = r.id AND r.deleted_at IS NOT NULL;
  • Ruben Backx approved this merge request

    approved this merge request

  • Ruben Backx resolved all threads

    resolved all threads

  • Ruben Backx started a merge train

    started a merge train

  • merged

  • Ruben Backx mentioned in commit 9476db16

    mentioned in commit 9476db16

  • Please register or sign in to reply
    Loading