Resolve "Deal with feedbacks that are associated with deleted requests"
What does this mr do?
Shows deleted feedback in the overview.
Screenshots
Manager View
TAM View
Admin View
Does this MR meet the acceptance criteria?
-
I have added a changelog entry to reflect the significant changes I made. -
Tests were created to test the feature. -
I have updated the documentation accordingly. -
I adhere to the style guide.
Closes #616 (closed)
Merge request reports
Activity
added difficultymedium priohigh + 1 deleted label
assigned to @hpage
added 1 commit
- bd721a09 - implementation of viewing soft deleted feedbacks
Henry Page, this merge request has policy violations and errors. To unblock this merge request, fix these items:
- Resolve all violations in the following merge request approval policies: Security check.
- Resolve the errors and re-run the pipeline.
If you think these items shouldn't be violations, ask eligible approvers of each policy to approve this merge request.
Errors- There is a mismatch between the scans of the source and target pipelines. The following scans are missing: Sast, Dast
Edited by GitLab Security Bot- Resolved by Henry Page
- Resolved by Ruben Backx
- Resolved by Henry Page
I think it would probably be better to add a
onDeletedRequest
field toFeedbackViewDTO
and then set that to true, so we can display all feedbacks in the same order as before. Also, should the feedback actually be deleted? We should probably just delete the request and not the feedback, because in my mind:- Request deleted -> feedback still visible 'on deleted request' for TA
- Feedback deleted -> feedback still visible to admin for accountability reasons but no longer to TA
added 80 commits
-
bd721a09...42481a8d - 77 commits from branch
development
- 51005c84 - temp commit
- 1ca15e90 - deal with deleted requests
- 273a2bfd - implement logic without migration changes
Toggle commit list-
bd721a09...42481a8d - 77 commits from branch
- Resolved by Ruben Backx
@rwbackx Everything is implemented as discussed before. This leaves 1 more thing, namely the preexisting migrations which deal with feedbacks. Do I simply get rid of them or???
- changeSet: id: 1668721308765-M1 author: Henry Page changes: - sql: comment: (MariaDB) Update feedbacks that have deleted requests to have same deletion time dbms: mariadb sql: UPDATE feedback AS f INNER JOIN request AS r ON r.id=f.request_id SET f.deleted_at = r.deleted_at WHERE r.deleted_at IS NOT NULL; - changeSet: id: 1668721308765-M2 author: Henry Page changes: - sql: comment: (PGSQL) Update feedbacks that have deleted requests to have same deletion time dbms: postgresql sql: UPDATE feedback AS f SET deleted_at = r.deleted_at FROM request AS r WHERE f.request_id = r.id AND r.deleted_at IS NOT NULL;
mentioned in commit 9476db16