Resolve "Lecturer schould be able to un-queue students after accepting a queue request"

What does this mr do?

Allows lecturers to free up requests in slotted labs.

Screenshots

Staff View

Student View

• Additional revoke button was added to the request page, such that a student can dequeue easier.

  

Does this MR meet the acceptance criteria?

• I have added a changelog entry to reflect the significant changes I made.
• Tests were created to test the feature.
• I have updated the documentation accordingly.
• I adhere to the style guide.

Make sure to read our contributing guide

Closes #640 (closed)

added difficultymedium priohigh statusdoing labels

assigned to @hpage

added 1 commit

• 24976592 - feat: staff can now revoke students' requests

Compare with previous version

Henry Page, this merge request has policy violations and errors. To unblock this merge request, fix these items:

• Resolve all violations in the following merge request approval policies: Security check.
• Resolve the errors and re-run the pipeline.

If you think these items shouldn't be violations, ask eligible approvers of each policy to approve this merge request.

Errors

• Pipeline configuration error: Artifacts required by policy Security check could not be found (Scan finding).

added 1 commit

• 2e26a2af - fix request event migration

Compare with previous version

changed the description

marked this merge request as ready

marked the checklist item I have added a changelog entry to reflect the significant changes I made. as completed

marked the checklist item Tests were created to test the feature. as completed

marked the checklist item I have updated the documentation accordingly. as completed

marked the checklist item I adhere to the style guide. as completed

In the student view, on the lab page we have 'Unenqueue' and on the request page we have here 'Revoke'. Both actions do the same thing, revoke the request. Is it not a bit confusing for the student to have the actions be named different things. Maybe we can rename the button in the request page 'Unenqueue'?

In the student view, when you now revoke a request through the request page, you get a pop-up to confirm whether you want to proceed with the action or not. But when you unenqueue through the lab page, it just does the action, without any confirmation. Should we add this pop-up there as well?

Also, talking about things being intuitive, in the teacher view: we have 4 buttons for taking actions in the bottom, but the new 'Revoke request' button is at the top. I understand that it might be too crowded if we add a fifth button at the bottom, but is the top placement ideal?

approved this merge request

unapproved this merge request

added 1 commit

• 6943200a - revision 2 changes

Compare with previous version

requested review from @rwbackx

approved this merge request

unapproved this merge request

resolved all threads

added 1 commit

• 011584c2 - [ManagerRevokeFeature] Change button placement & restrict feature access to manager+

Compare with previous version

requested review from @rwbackx

added 1 deleted label and removed statusdoing label

added 1 commit

• 8af1af01 - [ManagerRevokeFeature] Allow admins to revoke

Compare with previous version

added 1 commit

• 0621f7c9 - [ManagerRevokeFeature] Fix flaky test on revoking assertion

Compare with previous version

added 6 commits

• 0621f7c9...c1289093 - 5 commits from branch development
• 8d5e9f47 - [ManagerRevokeFeature] Fix merge conflicts

Compare with previous version

approved this merge request

started a merge train

merged

mentioned in commit defef8e2