Fix opening a request in a new tab
What does this mr do?
Closes #709 (closed). To verify, open the lab view or click the Requests in the header and Ctrl+Click a request, it should open in a new tab.
Actions taken to fix bug
Added to the check for what key is used to open the request in a new tab to also verify whether it's a meta-key (Mac's command key). On Mac this solved it, remains to check whether it work on other OSs?
Does this MR meet the acceptance criteria?
-
I have added a changelog entry to reflect the significant changes I made and the bug I fixed. -
A test was created to test the bug. -
I have updated the documentation accordingly. -
I adhere to the style guide.
Merge request reports
Activity
added difficultylow priolow + 1 deleted label
Marina Mădăraş, this merge request has policy violations and errors. To unblock this merge request, fix these items:
- Resolve all violations in the following merge request approval policies: Security check.
- Resolve the errors and re-run the pipeline.
If you think these items shouldn't be violations, ask eligible approvers of each policy to approve this merge request.
Errors- There is a mismatch between the scans of the source and target pipelines. The following scans are missing: Sast, Dast
Edited by GitLab Security Botadded typebug label
- Resolved by Otto Visser
Verified works on Linux as well (tried both Firefox and Konqueror). The only thing I'm missing now, is that I can middle-click on a lab to open it in a new tab, but I cannot middle-click a request. Ctrl-click works though.
Edited by Otto Visser
- Resolved by Henry Page
Would it be possible to have this in 1 place rather than having multiple occurrences of this behavior across 2 different files?
added 1 commit
- 220b949f - Refactor clicking logic and add support for middle click
mentioned in commit 8960474e