Resolve "Trying to create a lab without specifying ANY request type leads to OOPS screen"
What does this mr do?
For some reason the "required" does not work in our select tags. I tried to find out how to fix it but nothing worked, so I manually added the error checks.
Actions taken to fix bug
Does this MR meet the acceptance criteria?
-
I have added a changelog entry to reflect the significant changes I made and the bug I fixed. -
I adhere to the style guide.
Closes #552 (closed)
Merge request reports
Activity
added bug-bounty difficultylow priohigh typebug + 1 deleted label
assigned to @dsavvidi
Security policy violations have been resolved.
Edited by GitLab Security Botadded 71 commits
-
f6209a2c...a84f6d4d - 70 commits from branch
development
- 5e54407e - Merge branch 'development' into...
-
f6209a2c...a84f6d4d - 70 commits from branch
requested review from @hpage
requested review from @mmadara
I tested the functionality for single-course and shared editions. When I tried to make a (shared) lab, I was forced to input a request type for all assignments in all modules in the shared lab. Before, I was able to pick just a subset of the modules in the lab. Is this change intended?
Also, when I select just one module (out of multiple) and try to create the session, there is no message indicating I should pick all modules (the 'Create new session' button is unresponsive). It would be nice to have a message in the UI if we want the users to pick all modules when making a lab.
If I understand correctly, we want users to pick all assignments for the chosen modules but not all of the modules? In that case, if a course had an "Assignments" module with multiple assignments, how can we create a lab for a single assignment?
Also, for the second point, here are the steps I took:
- Ensure there is a course with at least two modules on Queue
- For this course, start creating a lab session (eg. Regular):
- Fill in the General and Location sections
- For the Requests section, pick only one module (also fill in assignment types for the module)
- Click on "Create session" (this is where the button is unresponsive for me)
- If you then choose an unselected module, there should be an error message under all assignments prompting you to indicate an assignment type for each one
requested review from @omilchi
mentioned in issue frontend#4