Skip to content

Resolve "FeedbackConverterDto Desynced"

Henry Page requested to merge 759-feedbackconverterdto-desynced into development

What does this mr do?

  • When updating to Spring3, the DTO Converter was moved to librador, but the postApply() steps for feedback were completely forgotten about and now it currently does not get used at all.

Works when labs are deleted even by considering deleted requests

image

admin can view everything

image

student is only exposed to anonymised counts (in this case its nothing, but page is rendered correctly)

image

Does this MR meet the acceptance criteria?

  • I have added a changelog entry to reflect the significant changes I made and the bug I fixed.
  • I have updated the documentation accordingly.
  • I adhere to the style guide.

Closes #759

Edited by Henry Page

Merge request reports

Loading