Resolve "FeedbackConverterDto Desynced"
What does this mr do?
- When updating to Spring3, the DTO Converter was moved to librador, but the
postApply()steps for feedback were completely forgotten about and now it currently does not get used at all.
Works when labs are deleted even by considering deleted requests
admin can view everything
student is only exposed to anonymised counts (in this case its nothing, but page is rendered correctly)
Does this MR meet the acceptance criteria?
-
I have added a changelog entry to reflect the significant changes I made and the bug I fixed. -
I have updated the documentation accordingly. -
I adhere to the style guide.
Closes #759 (closed)
Edited by Henry Page
Merge request reports
Activity
added difficultylow typebug labels
assigned to @hpage
added 1 commit
- 86cbf98d - [Fix Feedback] Apply old DTO Method to feedback rendering
Henry Page, this merge request has policy violations and errors. To unblock this merge request, fix these items:
- Resolve all violations in the following merge request approval policies: Security check.
- Resolve the errors and re-run the pipeline. If you think these items shouldn't be violations, ask eligible approvers of each policy to approve this merge request.
Errors
- There is a mismatch between the scans of the source and target pipelines. The following scans are missing: Dast, Secret detection
Comparison pipelines
Edited by GitLab Security Botstarted a merge train
mentioned in commit f3df3bf3
Please register or sign in to reply


