Resolve "Time slot shows wrong numbers if people retracted their request"

Summary

Fixes the incorrect reporting of time slot occupancy by not taking into account revoked requests anymore.

Checklist

All items on this checklist should be checked.

• I have added a changelog entry.
• I have added a test that catches the original bug behaviour.
• I adhere to the style guide.

How to review

• Create a slotted lab
• Enqueue as student
• Revoke your request
• As teacher, observe the number is 0 again

Issues and tasks closed

Closes #767 (closed) #761 (closed)

added task typebug label

added 1 commit

• 3f2b18dd - Fix time slot incorrect occupancy

Compare with previous version

Ruben Backx, this merge request has policy violations and errors. To unblock this merge request, fix these items:

• Resolve all violations in the following merge request approval policies: Security check. If you think these items shouldn't be violations, ask eligible approvers of each policy to approve this merge request.

Violations blocking this merge request

---

This merge request introduces these violations:

1. High · Bouncy Castle certificate parsing issues cause high CPU usage during parameter evaluation. · build.gradle.kts (Dependency scanning)
2. Critical · Apache Tomcat: Potential RCE and/or information disclosure and/or information corruption with partial PUT · build.gradle.kts (Dependency scanning)
3. High · Deserialization of Untrusted Data · build.gradle.kts (Dependency scanning)
4. Critical · Apache Tomcat Time-of-check Time-of-use (TOCTOU) Race Condition vulnerability · build.gradle.kts (Dependency scanning)
5. High · SslHandler doesn't correctly validate packets which can lead to native crash when using native SSLEngine · build.gradle.kts (Dependency scanning)
6. High · Bouncy Castle crafted signature and public key can be used to trigger an infinite loop · build.gradle.kts (Dependency scanning)
7. High · Bouncy Castle Java Cryptography API vulnerable to DNS poisoning · build.gradle.kts (Dependency scanning)
8. High · Apache Commons Improper Access Control vulnerability · build.gradle.kts (Dependency scanning)
9. High · jose4j uses weak cryptographic algorithm · build.gradle.kts (Dependency scanning)
10. High · Netplex Json-smart Uncontrolled Recursion vulnerability · build.gradle.kts (Dependency scanning)

More violations have been detected in addition to the list above.

Comparison pipelines

• Target branch (development): #1257018, #1252229
• Source branch (767-time-slot-shows-wrong-numbers-if-people-retracted-their-request): #1258529, #1258494

changed the description

started a merge train

approved this merge request

removed this merge request from the merge train because the pipeline did not succeed. Learn more.

enabled automatic add to merge train when checks pass

started a merge train

removed this merge request from the merge train because the pipeline did not succeed. Learn more.

added 1 commit

• c1395dbf - Fix failing test

Compare with previous version

reset approvals from @owvisser by pushing to the branch

approved this merge request

started a merge train

merged

mentioned in commit 414d5ce8