Skip to content
Snippets Groups Projects

Resolve "Progress table grades are incorrect"

Problem: inconsistency with how the grades were calculated/compared, the progress percentages ones were correct but because the actual data ones were wrongly calculated for module level, it seemed as if the percentages are wrong.

Solution: refactored to have only one consistent way :smile:

Note the problem was because it was comparing 7.0 to 60 (as passing grade), same for 1.0 vs 10 (for pass/fail ones) and giving off failing grade interestingly enough which made it harder to find :sweat_smile:

Another bug was that when calculating the percentage scores, it divided by the total rows instead of the rows that belonged to the assignment (or module) depending on the progress view. So if there were 3 assignments with 10 scores each it would divide (#passing scores in assignment 1)/30 instead of (#passing scores in assignment 1)/(#scores in assignment 1)

Demonstration:

Before: wrong grades in module level

before_module_level

Before: correct grades in assignment level (also stats are the same with module level if you notice)

before_assignment_level

After: correct grades in module level

after_module_level

After: correct grades in assignment level (pass/fail case demonstration)

passfail_assignment_level

Closes #137 (closed)

Edited by Danae Savvidi

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ada Turgut
  • Ada Turgut
  • Ada Turgut
  • Ada Turgut
  • Danae Savvidi added 1 commit

    added 1 commit

    • 6ce733a0 - Use isPassing, test isPassing

    Compare with previous version

  • Danae Savvidi resolved all threads

    resolved all threads

  • Danae Savvidi added 5 commits

    added 5 commits

    • 6ce733a0...65484dd9 - 4 commits from branch development
    • 7fb35159 - Merge branch 'development' into 137-progress-table-grades-are-incorrect

    Compare with previous version

  • Danae Savvidi added 1 commit

    added 1 commit

    • 09f556ab - small UI improvement for test submission

    Compare with previous version

    • Resolved by Danae Savvidi

      Thank you for the clarification! I think looks great, only thing I can add is it might still be useful to add a test for 'getModuleProgress' as I think right now there are no tests that cover it, also for 'getEditionProgress'.

  • Danae Savvidi added 24 commits

    added 24 commits

    • 09f556ab...b04c0228 - 23 commits from branch development
    • 16229c13 - Merge branch 'development' into '137-progress-table-grades-are-incorrect'

    Compare with previous version

  • Danae Savvidi added 16 commits

    added 16 commits

    • 16229c13...5fc7ad5d - 15 commits from branch development
    • a6284582 - Merge branch 'development' into 137-progress-table-grades-are-incorrect

    Compare with previous version

  • Danae Savvidi added 2 commits

    added 2 commits

    • ef89a6a4 - find another bug in module and edition progress stats & write 1 test
    • 756feb42 - more testing

    Compare with previous version

  • Danae Savvidi resolved all threads

    resolved all threads

  • Danae Savvidi changed the description

    changed the description

  • Ruben Backx approved this merge request

    approved this merge request

  • Ruben Backx started a merge train

    started a merge train

  • merged

  • Ruben Backx mentioned in commit 00edd9e7

    mentioned in commit 00edd9e7

  • Please register or sign in to reply
    Loading