Resolve "Progress table grades are incorrect"
Problem: inconsistency with how the grades were calculated/compared, the progress percentages ones were correct but because the actual data ones were wrongly calculated for module level, it seemed as if the percentages are wrong.
Solution: refactored to have only one consistent way
Note the problem was because it was comparing 7.0 to 60 (as passing grade), same for 1.0 vs 10 (for pass/fail ones) and giving off failing grade interestingly enough which made it harder to find
Another bug was that when calculating the percentage scores, it divided by the total rows instead of the rows that belonged to the assignment (or module) depending on the progress view. So if there were 3 assignments with 10 scores each it would divide (#passing scores in assignment 1)/30 instead of (#passing scores in assignment 1)/(#scores in assignment 1)
Demonstration:
Before: wrong grades in module level
Before: correct grades in assignment level (also stats are the same with module level if you notice)
After: correct grades in module level
After: correct grades in assignment level (pass/fail case demonstration)
Closes #137 (closed)
Merge request reports
Activity
assigned to @dsavvidi
added 1 commit
- 1b0e3296 - extract duplicate code/refactor, add new tests & fix module level stats
requested review from @rwbackx
added 4 commits
-
a8f8aa6e...a9104df5 - 3 commits from branch
development
- 14835251 - Merge branch 'development' into 137-progress-table-grades-are-incorrect
-
a8f8aa6e...a9104df5 - 3 commits from branch
added 1 commit
- e4dd40b8 - fix tests & replace `.collect(Collectors.toList())` with `.toList()` :)
mentioned in issue #128 (closed)
- Resolved by Danae Savvidi
- Resolved by Danae Savvidi
- Resolved by Danae Savvidi
- Resolved by Danae Savvidi
- Resolved by Danae Savvidi
added 5 commits
-
6ce733a0...65484dd9 - 4 commits from branch
development
- 7fb35159 - Merge branch 'development' into 137-progress-table-grades-are-incorrect
-
6ce733a0...65484dd9 - 4 commits from branch
- Resolved by Danae Savvidi
Thank you for the clarification! I think looks great, only thing I can add is it might still be useful to add a test for 'getModuleProgress' as I think right now there are no tests that cover it, also for 'getEditionProgress'.
added 24 commits
-
09f556ab...b04c0228 - 23 commits from branch
development
- 16229c13 - Merge branch 'development' into '137-progress-table-grades-are-incorrect'
-
09f556ab...b04c0228 - 23 commits from branch
added 16 commits
-
16229c13...5fc7ad5d - 15 commits from branch
development
- a6284582 - Merge branch 'development' into 137-progress-table-grades-are-incorrect
-
16229c13...5fc7ad5d - 15 commits from branch
mentioned in commit 00edd9e7