Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Submit
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Terraform modules
Analyze
Contributor analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
EIP
Labrador
Submit
Merge requests
!253
Resolve "Teachers submission view thinks latest submission is not latest submission when giving feedback."
Code
Review changes
Check out branch
Open in Workspace
Download
Patches
Plain diff
Expand sidebar
Merged
Resolve "Teachers submission view thinks latest submission is not latest submission when giving feedback."
146-teachers-submission-view-thinks-latest-submission-is-not-latest-submission-when-giving-feedback
into
development
Overview
6
Commits
4
Pipelines
0
Changes
4
Merged
Resolve "Teachers submission view thinks latest submission is not latest submission when giving feedback."
Danae Savvidi
requested to merge
146-teachers-submission-view-thinks-latest-submission-is-not-latest-submission-when-giving-feedback
into
development
9 months ago
Overview
6
Commits
4
Pipelines
0
Changes
4
Problem was backend wasn't setting the
isLatest
field correctly for submissions (now fixed).
Added the submission id on top of the feedback panel so it's easier for the user to identify which submission they are viewing.
Made the textual feedback required since if you click 'save' without any feedback or grade it crashes.
I saw we had some duplicate code which I removed.
Made save button disappear if submission is not the latest (you cannot give feedback on past submissions)
Closes
#146 (closed)
Edited
9 months ago
by
Danae Savvidi
1
0
Merge request reports
Loading
