Replace NetID with Email in Exports + Change Separator to Comma for valid CSV

Description

The NetID cannot appear along with the student number in a spreadsheet, so the NetID has been removed and replaced with the student email such that they can be contacted easily. Secondly, the exports will appear in a nicer format in Excel and other Spreadsheet applications if the separator between columns is a comma, not a semi-colon.

Changes

• Replaces the NetID field in exports with Email
• Changes the CSV separator from a semi-color to a comma in application-template.yaml (in main) and application.yaml (in tests)

Related Issues

• Resolves #49 (closed)
• Resolves #50 (closed)
• Resolves #57 (closed)

src/main/java/nl/tudelft/tam/service/ApplicationService.java

@@ -414,12 +414,12 @@ public class ApplicationService {
 	public Path exportApplications(String name, List<Application> applications) throws IOException {
 		personCache.get(applications.stream().map(a -> a.getId().getPersonId()));
 
-		String[] headers = new String[] { "Student number", "NetID", "Name", "Edition", "Job Offer",
+		String[] headers = new String[] { "Student Number", "Email", "Name", "Edition", "Job Offer",
 				"Status" };
 		Stream<String[]> data = applications.stream().map(app -> {
 			PersonSummaryDTO applicant = personCache.getOrThrow(app.getId().getPersonId());
 			EditionDetailsDTO edition = editionCache.getOrThrow(app.getJobOffer().getEditionId());
-			return new String[] { applicant.getNumber().toString(), applicant.getUsername(),
+			return new String[] { applicant.getNumber().toString(), applicant.getEmail(),
 					applicant.getDisplayName(), edition.getCourse().getName() + " - " + edition.getName(),
 					app.getJobOffer().getName(), app.getStatus().toString() };
 		});