Change hours input from time to text + Make overlays close on outer click
All threads resolved!
Description
- Overlays now close when clicking outside of the box
- The hours input has been changed from a
time
type to atext
type. This helps to prevent browser errors or needing to add AM/PM.
Related Issues
- Resolves #68 (closed)
Checklist
-
I have added a changelog entry to reflect the significant changes I made.
Edited by Timur Oberhuber
Merge request reports
Activity
changed milestone to %Working v2.0
added typebug + 1 deleted label
assigned to @toberhuber
requested review from @rbackx
- Resolved by Timur Oberhuber
Most overlays should not close when clicking outside, only the ones that are not some kind of form. Ideally we check if an overlay has some
data-closable
attribute and if it does, it can be closed by clicking outside.
- Resolved by Timur Oberhuber
Submitting a declaration gives an error
- Resolved by Timur Oberhuber
Putting
:00
in the box changes the value toNaN:00
added 5 commits
-
04613a71...05960151 - 4 commits from branch
dev
- 18c3c199 - Merge branch 'dev' into '68-new-declaration-errors'
-
04613a71...05960151 - 4 commits from branch
- Resolved by Timur Oberhuber
- Resolved by Timur Oberhuber
One more small thing: When entering a declaration time, if someone just enters 5, the time should be 5:00 and not give an error
added 28 commits
-
465bb3b4...7870996a - 27 commits from branch
dev
- ad4b20fc - Merge branch 'dev' into '68-new-declaration-errors'
-
465bb3b4...7870996a - 27 commits from branch
mentioned in commit e4c28f41
unassigned @toberhuber
Please register or sign in to reply